Title: [281015] trunk/Tools
- Revision
- 281015
- Author
- lmo...@igalia.com
- Date
- 2021-08-13 07:40:23 -0700 (Fri, 13 Aug 2021)
Log Message
[WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=229067
Reviewed by Carlos Garcia Campos.
* TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(testWebKitWebViewProcessCrashed): Make warnings non-fatal while waiting for the crash.
* TestWebKitAPI/glib/TestExpectations.json: Remove expectation
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (281014 => 281015)
--- trunk/Tools/ChangeLog 2021-08-13 14:16:31 UTC (rev 281014)
+++ trunk/Tools/ChangeLog 2021-08-13 14:40:23 UTC (rev 281015)
@@ -1,3 +1,14 @@
+2021-08-13 Lauro Moura <lmo...@igalia.com>
+
+ [WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing
+ https://bugs.webkit.org/show_bug.cgi?id=229067
+
+ Reviewed by Carlos Garcia Campos.
+
+ * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
+ (testWebKitWebViewProcessCrashed): Make warnings non-fatal while waiting for the crash.
+ * TestWebKitAPI/glib/TestExpectations.json: Remove expectation
+
2021-08-13 Martin Robinson <mrobin...@webkit.org>
Get lint-test-expectations passing
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp (281014 => 281015)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp 2021-08-13 14:16:31 UTC (rev 281014)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp 2021-08-13 14:40:23 UTC (rev 281015)
@@ -161,7 +161,9 @@
G_DBUS_CALL_FLAGS_NONE,
-1, 0, 0));
g_assert_null(result);
+ Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
g_main_loop_run(test->m_mainLoop);
+ Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);
test->m_expectedWebProcessCrash = false;
}
Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (281014 => 281015)
--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json 2021-08-13 14:16:31 UTC (rev 281014)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json 2021-08-13 14:40:23 UTC (rev 281015)
@@ -74,9 +74,6 @@
},
"TestWebExtensions": {
"subtests": {
- "/webkit/WebKitWebView/web-process-crashed": {
- "expected": {"wpe": {"status": ["FAIL", "PASS"], "bug": ["webkit.org/b/229067"]}}
- },
"/webkit/WebKitWebView/install-missing-plugins-permission-request": {
"expected": {"gtk": {"status": ["TIMEOUT", "FAIL"], "bug": ["webkit.org/b/147822", "webkit.org/b/210635"]}}
},
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
