Title: [281030] trunk
- Revision
- 281030
- Author
- you...@apple.com
- Date
- 2021-08-13 12:30:44 -0700 (Fri, 13 Aug 2021)
Log Message
Use profile auto level for WebRTC H264 encoder on Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=229071
<rdar://80345048>
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
AS H264 encoder will fail if its profile is too low compared to the size of the video.
Use autolevel to prevent this.
* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
LayoutTests:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (281029 => 281030)
--- trunk/LayoutTests/ChangeLog 2021-08-13 19:29:04 UTC (rev 281029)
+++ trunk/LayoutTests/ChangeLog 2021-08-13 19:30:44 UTC (rev 281030)
@@ -1,3 +1,13 @@
+2021-08-13 Youenn Fablet <you...@apple.com>
+
+ Use profile auto level for WebRTC H264 encoder on Apple Silicon
+ https://bugs.webkit.org/show_bug.cgi?id=229071
+ <rdar://80345048>
+
+ Reviewed by Eric Carlson.
+
+ * platform/mac/TestExpectations:
+
2021-08-13 Alex Christensen <achristen...@webkit.org>
Unreviewed, reverting r281009.
Modified: trunk/LayoutTests/platform/mac/TestExpectations (281029 => 281030)
--- trunk/LayoutTests/platform/mac/TestExpectations 2021-08-13 19:29:04 UTC (rev 281029)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2021-08-13 19:30:44 UTC (rev 281030)
@@ -2121,7 +2121,6 @@
[ arm64 ] webrtc/video.html [ Pass Timeout ]
[ arm64 ] webrtc/video-with-data-channel.html [ Pass Timeout ]
[ arm64 ] webrtc/video-unmute.html [ Pass Timeout ]
-[ arm64 ] webrtc/h264-high.html [ Skip ]
[ arm64 ] webrtc/vp9-profile2.html [ Skip ]
[ arm64 ] webrtc/captureCanvas-webrtc-software-h264-high.html [ Pass Failure ]
[ arm64 ] webrtc/h264-baseline.html [ Failure Timeout ]
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (281029 => 281030)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-08-13 19:29:04 UTC (rev 281029)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-08-13 19:30:44 UTC (rev 281030)
@@ -1,3 +1,15 @@
+2021-08-13 Youenn Fablet <you...@apple.com>
+
+ Use profile auto level for WebRTC H264 encoder on Apple Silicon
+ https://bugs.webkit.org/show_bug.cgi?id=229071
+ <rdar://80345048>
+
+ Reviewed by Eric Carlson.
+
+ AS H264 encoder will fail if its profile is too low compared to the size of the video.
+ Use autolevel to prevent this.
+ * Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+
2021-07-01 Youenn Fablet <you...@apple.com>
Disable ABSL_HAVE_THREAD_LOCAL in libwebrtc
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (281029 => 281030)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm 2021-08-13 19:29:04 UTC (rev 281029)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm 2021-08-13 19:30:44 UTC (rev 281030)
@@ -260,6 +260,7 @@
case webrtc::H264::kProfileConstrainedHigh:
case webrtc::H264::kProfileHigh:
+#if !defined(WEBRTC_ARCH_ARM64)
switch (profile_level_id.level) {
case webrtc::H264::kLevel3:
return kVTProfileLevel_H264_High_3_0;
@@ -289,6 +290,9 @@
case webrtc::H264::kLevel2_2:
return kVTProfileLevel_H264_High_AutoLevel;
}
+#else
+ return kVTProfileLevel_H264_High_AutoLevel;
+#endif
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
