Title: [281133] trunk/Source/WebCore
- Revision
- 281133
- Author
- commit-qu...@webkit.org
- Date
- 2021-08-17 03:16:41 -0700 (Tue, 17 Aug 2021)
Log Message
REGRESSION(r278981): [GStreamer][Debug] Assert crashes when running media/track tests
https://bugs.webkit.org/show_bug.cgi?id=229123
<rdar://problem/81978494>
Patch by Philippe Normand <pnorm...@igalia.com> on 2021-08-17
Reviewed by Xabier Rodriguez-Calvar.
Implement a dummy id() method for InbandTextTrackPrivateGStreamer.
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (281132 => 281133)
--- trunk/Source/WebCore/ChangeLog 2021-08-17 07:22:16 UTC (rev 281132)
+++ trunk/Source/WebCore/ChangeLog 2021-08-17 10:16:41 UTC (rev 281133)
@@ -1,3 +1,17 @@
+2021-08-17 Philippe Normand <pnorm...@igalia.com>
+
+ REGRESSION(r278981): [GStreamer][Debug] Assert crashes when running media/track tests
+ https://bugs.webkit.org/show_bug.cgi?id=229123
+ <rdar://problem/81978494>
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Implement a dummy id() method for InbandTextTrackPrivateGStreamer.
+
+ * platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
+ (WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
+ * platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
+
2021-08-17 Jer Noble <jer.no...@apple.com>
LayoutTests imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-* are flakey
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp (281132 => 281133)
--- trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp 2021-08-17 07:22:16 UTC (rev 281132)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp 2021-08-17 10:16:41 UTC (rev 281133)
@@ -44,6 +44,7 @@
, TrackPrivateBaseGStreamer(this, index, pad)
, m_kind(Kind::Subtitles)
{
+ m_id = "T" + String::number(index);
m_eventProbe = gst_pad_add_probe(m_pad.get(), GST_PAD_PROBE_TYPE_EVENT_DOWNSTREAM, [] (GstPad*, GstPadProbeInfo* info, gpointer userData) -> GstPadProbeReturn {
auto* track = static_cast<InbandTextTrackPrivateGStreamer*>(userData);
switch (GST_EVENT_TYPE(gst_pad_probe_info_get_event(info))) {
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h (281132 => 281133)
--- trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h 2021-08-17 07:22:16 UTC (rev 281132)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h 2021-08-17 10:16:41 UTC (rev 281133)
@@ -58,6 +58,7 @@
Kind kind() const override { return m_kind; }
+ AtomString id() const override { return m_id; }
AtomString label() const override { return m_label; }
AtomString language() const override { return m_language; }
@@ -80,6 +81,7 @@
String m_streamId;
Kind m_kind;
Lock m_sampleMutex;
+ AtomString m_id;
};
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
