Title: [281217] trunk/Source/WTF
- Revision
- 281217
- Author
- rn...@webkit.org
- Date
- 2021-08-18 17:20:53 -0700 (Wed, 18 Aug 2021)
Log Message
[ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=229250
Reviewed by Wenson Hsieh.
Disable the assertion when Web Thread is enabled for now.
* wtf/CheckedRef.h:
(WTF::SingleThreadIntegralWrapper::assertThread const):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (281216 => 281217)
--- trunk/Source/WTF/ChangeLog 2021-08-19 00:20:00 UTC (rev 281216)
+++ trunk/Source/WTF/ChangeLog 2021-08-19 00:20:53 UTC (rev 281217)
@@ -1,3 +1,15 @@
+2021-08-18 Ryosuke Niwa <rn...@webkit.org>
+
+ [ iOS Debug ] 12 TestWebKitAPI.WebKitLegacy. tests are crashing
+ https://bugs.webkit.org/show_bug.cgi?id=229250
+
+ Reviewed by Wenson Hsieh.
+
+ Disable the assertion when Web Thread is enabled for now.
+
+ * wtf/CheckedRef.h:
+ (WTF::SingleThreadIntegralWrapper::assertThread const):
+
2021-08-18 Megan Gardner <megan_gard...@apple.com>
Remove unneeded UIKitSPI declarations
Modified: trunk/Source/WTF/wtf/CheckedRef.h (281216 => 281217)
--- trunk/Source/WTF/wtf/CheckedRef.h 2021-08-19 00:20:00 UTC (rev 281216)
+++ trunk/Source/WTF/wtf/CheckedRef.h 2021-08-19 00:20:53 UTC (rev 281217)
@@ -248,10 +248,14 @@
SingleThreadIntegralWrapper& operator--();
private:
+#if ASSERT_ENABLED && !USE(WEB_THREAD)
void assertThread() const { ASSERT(m_thread.ptr() == &Thread::current()); }
+#else
+ constexpr void assertThread() const { }
+#endif
IntegralType m_value;
-#if ASSERT_ENABLED
+#if ASSERT_ENABLED && !USE(WEB_THREAD)
Ref<Thread> m_thread;
#endif
};
@@ -259,7 +263,7 @@
template <typename IntegralType>
inline SingleThreadIntegralWrapper<IntegralType>::SingleThreadIntegralWrapper(IntegralType value)
: m_value { value }
-#if ASSERT_ENABLED
+#if ASSERT_ENABLED && !USE(WEB_THREAD)
, m_thread { Thread::current() }
#endif
{ }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
