Title: [281273] trunk/Source/WebKitLegacy
- Revision
- 281273
- Author
- megan_gard...@apple.com
- Date
- 2021-08-19 15:25:01 -0700 (Thu, 19 Aug 2021)
Log Message
Remove old unused code and out of date comments.
https://bugs.webkit.org/show_bug.cgi?id=229210
Reviewed by Anders Carlsson.
Source/WebKitLegacy/ios:
* WebKit.iOS.exp:
Source/WebKitLegacy/mac:
* WebView/WebView.mm:
* WebView/WebViewPrivate.h:
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (281272 => 281273)
--- trunk/Source/WebKitLegacy/ios/ChangeLog 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog 2021-08-19 22:25:01 UTC (rev 281273)
@@ -1,3 +1,12 @@
+2021-08-19 Megan Gardner <megan_gard...@apple.com>
+
+ Remove old unused code and out of date comments.
+ https://bugs.webkit.org/show_bug.cgi?id=229210
+
+ Reviewed by Anders Carlsson.
+
+ * WebKit.iOS.exp:
+
2021-05-30 Darin Adler <da...@apple.com>
Remove WTF::Optional synonym for std::optional, using that class template directly instead
Modified: trunk/Source/WebKitLegacy/ios/WebKit.iOS.exp (281272 => 281273)
--- trunk/Source/WebKitLegacy/ios/WebKit.iOS.exp 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/ios/WebKit.iOS.exp 2021-08-19 22:25:01 UTC (rev 281273)
@@ -40,8 +40,5 @@
_WebViewProgressBackgroundColorKey
_WebViewProgressEstimatedProgressKey
-# For WebInspector notifications
-__WebViewRemoteInspectorHasSessionChangedNotification
-
# WebKit1 internal types exposed for WebKit2.
.objc_class_name_WebGeolocationCoreLocationProvider
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (281272 => 281273)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-08-19 22:25:01 UTC (rev 281273)
@@ -1,3 +1,13 @@
+2021-08-19 Megan Gardner <megan_gard...@apple.com>
+
+ Remove old unused code and out of date comments.
+ https://bugs.webkit.org/show_bug.cgi?id=229210
+
+ Reviewed by Anders Carlsson.
+
+ * WebView/WebView.mm:
+ * WebView/WebViewPrivate.h:
+
2021-08-19 Alex Christensen <achristen...@webkit.org>
Remove more non-inclusive language from Source
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (281272 => 281273)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2021-08-19 22:25:01 UTC (rev 281273)
@@ -959,11 +959,6 @@
NSString *_WebViewDidStartAcceleratedCompositingNotification = @"_WebViewDidStartAcceleratedCompositing";
NSString * const WebViewWillCloseNotification = @"WebViewWillCloseNotification";
-#if ENABLE(REMOTE_INSPECTOR)
-// FIXME: Legacy, remove this, switch to something from _javascript_Core Inspector::RemoteInspectorServer.
-NSString *_WebViewRemoteInspectorHasSessionChangedNotification = @"_WebViewRemoteInspectorHasSessionChangedNotification";
-#endif
-
@interface WebProgressItem : NSObject
{
@public
@@ -8105,13 +8100,11 @@
#if !PLATFORM(IOS_FAMILY)
@implementation WebView (WebViewGrammarChecking)
-// FIXME: This method should be merged into WebViewEditing when we're not in API freeze
- (BOOL)isGrammarCheckingEnabled
{
return grammarCheckingEnabled;
}
-// FIXME: This method should be merged into WebViewEditing when we're not in API freeze
- (void)setGrammarCheckingEnabled:(BOOL)flag
{
if (grammarCheckingEnabled == flag)
@@ -8128,7 +8121,6 @@
[[self mainFrame] _unmarkAllBadGrammar];
}
-// FIXME: This method should be merged into WebIBActions when we're not in API freeze
- (void)toggleGrammarChecking:(id)sender
{
[self setGrammarCheckingEnabled:![self isGrammarCheckingEnabled]];
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h (281272 => 281273)
--- trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h 2021-08-19 22:23:31 UTC (rev 281272)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebViewPrivate.h 2021-08-19 22:25:01 UTC (rev 281273)
@@ -105,13 +105,6 @@
// One of the subviews of the WebView entered compositing mode.
extern NSString *_WebViewDidStartAcceleratedCompositingNotification;
-#if ENABLE_REMOTE_INSPECTOR
-// FIXME: Legacy, remove this, switch to something from _javascript_Core Inspector::RemoteInspectorServer.
-// Notification when the number of inspector sessions becomes non-zero or returns to 0.
-// Check the current state via -[WebView _hasRemoteInspectorSession].
-extern NSString *_WebViewRemoteInspectorHasSessionChangedNotification;
-#endif
-
#if TARGET_OS_IPHONE
extern NSString *WebQuickLookFileNameKey;
extern NSString *WebQuickLookUTIKey;
@@ -160,11 +153,6 @@
WebPaginationModeRightToLeft,
WebPaginationModeTopToBottom,
WebPaginationModeBottomToTop,
-#if TARGET_OS_IPHONE
- // FIXME: Remove these once UIKit has switched to the above.
- WebPaginationModeHorizontal = WebPaginationModeLeftToRight,
- WebPaginationModeVertical = WebPaginationModeTopToBottom,
-#endif
} WebPaginationMode;
enum {
@@ -949,11 +937,9 @@
@interface WebView (WebViewGrammarChecking)
-// FIXME: These two methods should be merged into WebViewEditing when we're not in API freeze
- (BOOL)isGrammarCheckingEnabled;
- (void)setGrammarCheckingEnabled:(BOOL)flag;
-// FIXME: This method should be merged into WebIBActions when we're not in API freeze
- (void)toggleGrammarChecking:(id)sender;
@end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
