Title: [281334] trunk/Source/WebCore
- Revision
- 281334
- Author
- wenson_hs...@apple.com
- Date
- 2021-08-20 13:44:07 -0700 (Fri, 20 Aug 2021)
Log Message
Followup to <trac.webkit.org/r281288>
https://bugs.webkit.org/show_bug.cgi?id=229269
rdar://81349236
Reviewed by Jer Noble.
Make two minor adjustments after the changes in r281288:
1. Rename `keyPathsForValuesAffectingValueCanBeginTouchBarScrubbing` to just
`keyPathsForValuesAffectingCanBeginTouchBarScrubbing`, since the Objective-C property name is
`-canBeginTouchBarScrubbing` rather than `-valueCanBeginTouchBarScrubbing`.
2. After fixing (1), the implementation of this method is no longer dead code, so we'll to make sure that the
`NSSet` we create and return contains valid Objective-C objects (i.e. NSString instead of `const char*`) --
in particular, this affects `"contentDuration"`.
* platform/mac/WebPlaybackControlsManager.mm:
(+[WebPlaybackControlsManager keyPathsForValuesAffectingCanBeginTouchBarScrubbing]):
(+[WebPlaybackControlsManager keyPathsForValuesAffectingValueCanBeginTouchBarScrubbing]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (281333 => 281334)
--- trunk/Source/WebCore/ChangeLog 2021-08-20 20:05:57 UTC (rev 281333)
+++ trunk/Source/WebCore/ChangeLog 2021-08-20 20:44:07 UTC (rev 281334)
@@ -1,3 +1,25 @@
+2021-08-20 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Followup to <trac.webkit.org/r281288>
+ https://bugs.webkit.org/show_bug.cgi?id=229269
+ rdar://81349236
+
+ Reviewed by Jer Noble.
+
+ Make two minor adjustments after the changes in r281288:
+
+ 1. Rename `keyPathsForValuesAffectingValueCanBeginTouchBarScrubbing` to just
+ `keyPathsForValuesAffectingCanBeginTouchBarScrubbing`, since the Objective-C property name is
+ `-canBeginTouchBarScrubbing` rather than `-valueCanBeginTouchBarScrubbing`.
+
+ 2. After fixing (1), the implementation of this method is no longer dead code, so we'll to make sure that the
+ `NSSet` we create and return contains valid Objective-C objects (i.e. NSString instead of `const char*`) --
+ in particular, this affects `"contentDuration"`.
+
+ * platform/mac/WebPlaybackControlsManager.mm:
+ (+[WebPlaybackControlsManager keyPathsForValuesAffectingCanBeginTouchBarScrubbing]):
+ (+[WebPlaybackControlsManager keyPathsForValuesAffectingValueCanBeginTouchBarScrubbing]): Deleted.
+
2021-08-20 Carlos Alberto Lopez Perez <clo...@igalia.com>
REGRESSION(r274166): [GTK] It broke run-_javascript_core-tests causing all tests to use lot of memory
Modified: trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm (281333 => 281334)
--- trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm 2021-08-20 20:05:57 UTC (rev 281333)
+++ trunk/Source/WebCore/platform/mac/WebPlaybackControlsManager.mm 2021-08-20 20:44:07 UTC (rev 281334)
@@ -134,9 +134,9 @@
completionHandler(@[ ]);
}
-+ (NSSet<NSString *> *)keyPathsForValuesAffectingValueCanBeginTouchBarScrubbing
++ (NSSet<NSString *> *)keyPathsForValuesAffectingCanBeginTouchBarScrubbing
{
- return [NSSet setWithObjects:@"canSeek", "contentDuration", nil];
+ return [NSSet setWithObjects:@"canSeek", @"contentDuration", nil];
}
- (BOOL)canBeginTouchBarScrubbing
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
