Title: [281658] trunk/LayoutTests
Revision
281658
Author
pan...@apple.com
Date
2021-08-26 14:59:19 -0700 (Thu, 26 Aug 2021)

Log Message

[ EWS Catalina ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is flaky timing out / failing
https://bugs.webkit.org/show_bug.cgi?id=229459

Reviewed by Devin Rousso.

Increase timings slightly to widen the window during which we receive messages while paused in the debugger and
also delay the echo server's response further.

* http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py:
(web_socket_transfer_data):
* http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (281657 => 281658)


--- trunk/LayoutTests/ChangeLog	2021-08-26 21:38:59 UTC (rev 281657)
+++ trunk/LayoutTests/ChangeLog	2021-08-26 21:59:19 UTC (rev 281658)
@@ -1,3 +1,18 @@
+2021-08-26  Patrick Angle  <pan...@apple.com>
+
+        [ EWS Catalina ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is flaky timing out / failing
+        https://bugs.webkit.org/show_bug.cgi?id=229459
+
+        Reviewed by Devin Rousso.
+
+        Increase timings slightly to widen the window during which we receive messages while paused in the debugger and
+        also delay the echo server's response further.
+
+        * http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py:
+        (web_socket_transfer_data):
+        * http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html:
+        * platform/mac/TestExpectations:
+
 2021-08-26  Robert Jenner  <jen...@apple.com>
 
         [ Catalina+ wk1 ] css2.1/20110323/replaced-intrinsic-003.htm is a flaky text failure

Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py (281657 => 281658)


--- trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py	2021-08-26 21:38:59 UTC (rev 281657)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/echo-delayed_wsh.py	2021-08-26 21:59:19 UTC (rev 281658)
@@ -9,5 +9,5 @@
 def web_socket_transfer_data(request):
     # Echo message back
     message = msgutil.receive_message(request)
-    sleep(0.1)
+    sleep(0.25)
     msgutil.send_message(request, message)

Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html (281657 => 281658)


--- trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html	2021-08-26 21:38:59 UTC (rev 281657)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html	2021-08-26 21:59:19 UTC (rev 281658)
@@ -50,12 +50,12 @@
                         InspectorTest.log("Pausing script execution with `debugger` statement.");
                         InspectorTest.evaluateInPage(`debugger`);
 
-                        // The WebSocket echos with a 100ms delay, so wait a bit longer than that before resuming to
+                        // The WebSocket echos with a 250ms delay, so wait a bit longer than that before resuming to
                         // ensure we receive the message while still paused.
                         setTimeout(() => {
                         	InspectorTest.log("Resuming script execution.")
                         	WI.debuggerManager.resume().catch(reject);
-                        }, 200);
+                        }, 500);
                     } else if (frameAddedCount === 2) {
 
                         InspectorTest.expectEqual(frame.data, "Hello World! Привет Мир!", "Frame data should be 'Hello World! Привет Мир!'");

Modified: trunk/LayoutTests/platform/mac/TestExpectations (281657 => 281658)


--- trunk/LayoutTests/platform/mac/TestExpectations	2021-08-26 21:38:59 UTC (rev 281657)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-08-26 21:59:19 UTC (rev 281658)
@@ -656,8 +656,6 @@
 
 webkit.org/b/89153 http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]
 
-webkit.org/b/229459 [ Debug ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html [ Pass Failure Timeout ]
-
 # <rdar://problem/16696298>
 webkit.org/b/131886 webgl/1.0.3/conformance/textures/texture-size-limit.html [ Pass Failure ]
 webkit.org/b/131886 fast/canvas/webgl/webgl-compressed-texture-size-limit.html [ Pass Failure Timeout ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to