Title: [281934] trunk/Source/WebCore
- Revision
- 281934
- Author
- achristen...@apple.com
- Date
- 2021-09-02 10:23:32 -0700 (Thu, 02 Sep 2021)
Log Message
Remove optimistic assertion from r281860
https://bugs.webkit.org/show_bug.cgi?id=229751
This assertion was being hit in debug WK1 tests because of the way ResourceHandle updates timing data.
When it is hit, there is no issue. It is replacing data with equal data.
* page/PerformanceNavigationTiming.cpp:
(WebCore::PerformanceNavigationTiming::navigationFinished):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (281933 => 281934)
--- trunk/Source/WebCore/ChangeLog 2021-09-02 17:20:42 UTC (rev 281933)
+++ trunk/Source/WebCore/ChangeLog 2021-09-02 17:23:32 UTC (rev 281934)
@@ -1,3 +1,14 @@
+2021-09-02 Alex Christensen <achristen...@webkit.org>
+
+ Remove optimistic assertion from r281860
+ https://bugs.webkit.org/show_bug.cgi?id=229751
+
+ This assertion was being hit in debug WK1 tests because of the way ResourceHandle updates timing data.
+ When it is hit, there is no issue. It is replacing data with equal data.
+
+ * page/PerformanceNavigationTiming.cpp:
+ (WebCore::PerformanceNavigationTiming::navigationFinished):
+
2021-09-02 Tim Nguyen <n...@apple.com>
Add more inert checks for selection-related functionality
Modified: trunk/Source/WebCore/page/PerformanceNavigationTiming.cpp (281933 => 281934)
--- trunk/Source/WebCore/page/PerformanceNavigationTiming.cpp 2021-09-02 17:20:42 UTC (rev 281933)
+++ trunk/Source/WebCore/page/PerformanceNavigationTiming.cpp 2021-09-02 17:23:32 UTC (rev 281934)
@@ -144,8 +144,6 @@
void PerformanceNavigationTiming::navigationFinished(const NetworkLoadMetrics& metrics)
{
m_documentLoadTiming.markEndTime();
-
- ASSERT(!m_resourceTiming.networkLoadMetrics().responseEnd);
m_resourceTiming.networkLoadMetrics() = metrics;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
