Title: [281952] trunk/Tools
- Revision
- 281952
- Author
- jbed...@apple.com
- Date
- 2021-09-02 14:09:15 -0700 (Thu, 02 Sep 2021)
Log Message
[webkitpy] WrappedPopen breaks process returncode
https://bugs.webkit.org/show_bug.cgi?id=229824
Reviewed by Carlos Alberto Lopez Perez.
* Scripts/webkitpy/common/system/executive.py:
(WrappedPopen.__init__): Define underlying object.
(WrappedPopen.returncode): Return underlying object's returncode.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (281951 => 281952)
--- trunk/Tools/ChangeLog 2021-09-02 20:41:18 UTC (rev 281951)
+++ trunk/Tools/ChangeLog 2021-09-02 21:09:15 UTC (rev 281952)
@@ -1,3 +1,14 @@
+2021-09-02 Jonathan Bedard <jbed...@apple.com>
+
+ [webkitpy] WrappedPopen breaks process returncode
+ https://bugs.webkit.org/show_bug.cgi?id=229824
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ * Scripts/webkitpy/common/system/executive.py:
+ (WrappedPopen.__init__): Define underlying object.
+ (WrappedPopen.returncode): Return underlying object's returncode.
+
2021-09-02 Carlos Alberto Lopez Perez <clo...@igalia.com>
[GTK][WPE] Port API test runner to python3 (v2)
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (281951 => 281952)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2021-09-02 20:41:18 UTC (rev 281951)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2021-09-02 21:09:15 UTC (rev 281952)
@@ -83,11 +83,16 @@
class WrappedPopen(object):
def __init__(self, popen):
- for attribute in dir(popen):
- if attribute.startswith('__'):
+ self._popen = popen
+ for attribute in dir(self._popen):
+ if attribute.startswith('__') or attribute == 'returncode':
continue
- setattr(self, attribute, getattr(popen, attribute))
+ setattr(self, attribute, getattr(self._popen, attribute))
+ @property
+ def returncode(self):
+ return self._popen.returncode
+
def __enter__(self):
return self
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
