Title: [282177] trunk/Source/WebKit
- Revision
- 282177
- Author
- hironori.fu...@sony.com
- Date
- 2021-09-08 15:54:37 -0700 (Wed, 08 Sep 2021)
Log Message
REGRESSION(r282115): undefined reference to `IPC::messageArgumentDescriptions(IPC::MessageName)' in Debug build
https://bugs.webkit.org/show_bug.cgi?id=230064
Unreviewed build fix.
Debug build of non-Cocoa ports were broken since r282115 started
to use IPC::messageArgumentDescriptions for debug logging.
However, MessageArgumentDescriptions.cpp has a long-standing
compilation problem for non-Cocoa ports.
Temporarily disabled the debug logging for non-Cocoa ports by
using ENABLE(IPC_TESTING_API) macro. I'll revert this change after
I will fix the fundamental problem of messages.py.
* Platform/IPC/HandleMessage.h:
(IPC::logMessageImpl):
(IPC::logReply):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (282176 => 282177)
--- trunk/Source/WebKit/ChangeLog 2021-09-08 22:04:14 UTC (rev 282176)
+++ trunk/Source/WebKit/ChangeLog 2021-09-08 22:54:37 UTC (rev 282177)
@@ -1,3 +1,23 @@
+2021-09-08 Fujii Hironori <hironori.fu...@sony.com>
+
+ REGRESSION(r282115): undefined reference to `IPC::messageArgumentDescriptions(IPC::MessageName)' in Debug build
+ https://bugs.webkit.org/show_bug.cgi?id=230064
+
+ Unreviewed build fix.
+
+ Debug build of non-Cocoa ports were broken since r282115 started
+ to use IPC::messageArgumentDescriptions for debug logging.
+ However, MessageArgumentDescriptions.cpp has a long-standing
+ compilation problem for non-Cocoa ports.
+
+ Temporarily disabled the debug logging for non-Cocoa ports by
+ using ENABLE(IPC_TESTING_API) macro. I'll revert this change after
+ I will fix the fundamental problem of messages.py.
+
+ * Platform/IPC/HandleMessage.h:
+ (IPC::logMessageImpl):
+ (IPC::logReply):
+
2021-09-08 Sihui Liu <sihui_...@apple.com>
Remove unnecessary WTF:: in WebsiteDataStore files
Modified: trunk/Source/WebKit/Platform/IPC/HandleMessage.h (282176 => 282177)
--- trunk/Source/WebKit/Platform/IPC/HandleMessage.h 2021-09-08 22:04:14 UTC (rev 282176)
+++ trunk/Source/WebKit/Platform/IPC/HandleMessage.h 2021-09-08 22:54:37 UTC (rev 282177)
@@ -47,7 +47,7 @@
constexpr unsigned loggingContainerSizeLimit = 200;
-#if !LOG_DISABLED
+#if !LOG_DISABLED && ENABLE(IPC_TESTING_API)
enum class ForReply : bool { No, Yes };
inline TextStream textStreamForLogging(const Connection& connection, MessageName messageName, ForReply forReply)
@@ -73,7 +73,7 @@
template<typename ArgsTuple, size_t... ArgsIndex>
void logMessageImpl(const Connection& connection, MessageName messageName, const ArgsTuple& args, std::index_sequence<ArgsIndex...>)
{
-#if !LOG_DISABLED
+#if !LOG_DISABLED && ENABLE(IPC_TESTING_API)
auto stream = textStreamForLogging(connection, messageName, ForReply::No);
if (auto argumentDescriptions = messageArgumentDescriptions(messageName))
@@ -96,7 +96,7 @@
template<typename... T>
void logReply(const Connection& connection, MessageName messageName, const T&... args)
{
-#if !LOG_DISABLED
+#if !LOG_DISABLED && ENABLE(IPC_TESTING_API)
if (!sizeof...(T))
return;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
