Title: [282438] trunk
- Revision
- 282438
- Author
- [email protected]
- Date
- 2021-09-14 22:38:27 -0700 (Tue, 14 Sep 2021)
Log Message
imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change* tests fail
https://bugs.webkit.org/show_bug.cgi?id=203508
Patch by Rob Buis <[email protected]> on 2021-09-14
Reviewed by Simon Fraser.
Source/WebCore:
For replaced elements like images, non specified min/max logical widths are a
reason for re-layout after intrinsic size change (for example min-width: min-content).
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):
LayoutTests:
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (282437 => 282438)
--- trunk/LayoutTests/ChangeLog 2021-09-15 05:09:05 UTC (rev 282437)
+++ trunk/LayoutTests/ChangeLog 2021-09-15 05:38:27 UTC (rev 282438)
@@ -1,3 +1,12 @@
+2021-09-14 Rob Buis <[email protected]>
+
+ imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change* tests fail
+ https://bugs.webkit.org/show_bug.cgi?id=203508
+
+ Reviewed by Simon Fraser.
+
+ * TestExpectations:
+
2021-09-14 Eric Hutchison <[email protected]>
Remove test expectations for imported/w3c/web-platform-tests/resource-timing/status-codes-create-entry.html.
Modified: trunk/LayoutTests/TestExpectations (282437 => 282438)
--- trunk/LayoutTests/TestExpectations 2021-09-15 05:09:05 UTC (rev 282437)
+++ trunk/LayoutTests/TestExpectations 2021-09-15 05:38:27 UTC (rev 282438)
@@ -3415,14 +3415,6 @@
webkit.org/b/203509 imported/w3c/web-platform-tests/css/css-sizing/auto-scrollbar-inside-stf-abspos.html [ ImageOnlyFailure ]
webkit.org/b/203510 imported/w3c/web-platform-tests/css/css-sizing/clone-intrinsic-size.html [ ImageOnlyFailure ]
webkit.org/b/203511 imported/w3c/web-platform-tests/css/css-sizing/clone-nowrap-intrinsic-size-bidi.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-001.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-002.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-003.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-004.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-005.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-006.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-007.html [ ImageOnlyFailure ]
-webkit.org/b/203508 imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change-008.html [ ImageOnlyFailure ]
webkit.org/b/203512 imported/w3c/web-platform-tests/css/css-sizing/intrinsic-percent-non-replaced-004.html [ ImageOnlyFailure ]
webkit.org/b/203512 imported/w3c/web-platform-tests/css/css-sizing/intrinsic-percent-non-replaced-005.html [ ImageOnlyFailure ]
webkit.org/b/203513 imported/w3c/web-platform-tests/css/css-sizing/percentage-height-replaced-content-in-auto-cb.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (282437 => 282438)
--- trunk/Source/WebCore/ChangeLog 2021-09-15 05:09:05 UTC (rev 282437)
+++ trunk/Source/WebCore/ChangeLog 2021-09-15 05:38:27 UTC (rev 282438)
@@ -1,3 +1,16 @@
+2021-09-14 Rob Buis <[email protected]>
+
+ imported/w3c/web-platform-tests/css/css-sizing/image-min-max-content-intrinsic-size-change* tests fail
+ https://bugs.webkit.org/show_bug.cgi?id=203508
+
+ Reviewed by Simon Fraser.
+
+ For replaced elements like images, non specified min/max logical widths are a
+ reason for re-layout after intrinsic size change (for example min-width: min-content).
+
+ * rendering/RenderReplaced.cpp:
+ (WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):
+
2021-09-14 Don Olmstead <[email protected]>
Non-unified build fixes, mid September 2021 edition
Modified: trunk/Source/WebCore/rendering/RenderReplaced.cpp (282437 => 282438)
--- trunk/Source/WebCore/rendering/RenderReplaced.cpp 2021-09-15 05:09:05 UTC (rev 282437)
+++ trunk/Source/WebCore/rendering/RenderReplaced.cpp 2021-09-15 05:38:27 UTC (rev 282438)
@@ -373,7 +373,7 @@
setPreferredLogicalWidthsDirty(true);
// If the actual area occupied by the image has changed and it is not constrained by style then a layout is required.
- bool imageSizeIsConstrained = style().logicalWidth().isSpecified() && style().logicalHeight().isSpecified();
+ bool imageSizeIsConstrained = style().logicalWidth().isSpecified() && style().logicalHeight().isSpecified() && !style().logicalMinWidth().isIntrinsic() && !style().logicalMaxWidth().isIntrinsic();
// FIXME: We only need to recompute the containing block's preferred size
// if the containing block's size depends on the image's size (i.e., the container uses shrink-to-fit sizing).
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
