Title: [282871] trunk/Source/WebCore
- Revision
- 282871
- Author
- an...@apple.com
- Date
- 2021-09-22 06:22:29 -0700 (Wed, 22 Sep 2021)
Log Message
[LFC][Integration] Remove ALLOW_ coverage defines
https://bugs.webkit.org/show_bug.cgi?id=230608
Reviewed by Alan Bujtas.
They are not useful anymore.
* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (282870 => 282871)
--- trunk/Source/WebCore/ChangeLog 2021-09-22 11:28:59 UTC (rev 282870)
+++ trunk/Source/WebCore/ChangeLog 2021-09-22 13:22:29 UTC (rev 282871)
@@ -1,3 +1,15 @@
+2021-09-22 Antti Koivisto <an...@apple.com>
+
+ [LFC][Integration] Remove ALLOW_ coverage defines
+ https://bugs.webkit.org/show_bug.cgi?id=230608
+
+ Reviewed by Alan Bujtas.
+
+ They are not useful anymore.
+
+ * layout/integration/LayoutIntegrationCoverage.cpp:
+ (WebCore::LayoutIntegration::canUseForChild):
+
2021-09-22 Fujii Hironori <hironori.fu...@sony.com>
[Win][MSVC] REGRESSION(r282860): ClipboardItemBindingsDataSource.cpp(147): error C2955: 'WTF::Ref': use of class template requires template argument list
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (282870 => 282871)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2021-09-22 11:28:59 UTC (rev 282870)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2021-09-22 13:22:29 UTC (rev 282871)
@@ -45,11 +45,6 @@
#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
-#define ALLOW_IMAGES 1
-#define ALLOW_ALL_REPLACED 1
-#define ALLOW_INLINE_BLOCK 1
-#define ALLOW_INLINES 1
-
#ifndef NDEBUG
#define SET_REASON_AND_RETURN_IF_NEEDED(reason, reasons, includeReasons) { \
reasons.add(AvoidanceReason::reason); \
@@ -527,7 +522,6 @@
SET_REASON_AND_RETURN_IF_NEEDED(UnsupportedFieldset, reasons, includeReasons)
}
-#if ALLOW_IMAGES || ALLOW_ALL_REPLACED || ALLOW_INLINE_BLOCK
auto isSupportedStyle = [] (const auto& style) {
if (style.boxShadow())
return false;
@@ -535,8 +529,7 @@
return false;
return true;
};
-#endif
-#if ALLOW_IMAGES || ALLOW_ALL_REPLACED
+
if (is<RenderReplaced>(child)) {
auto& replaced = downcast<RenderReplaced>(child);
if (replaced.isFloating() || replaced.isPositioned())
@@ -554,14 +547,9 @@
SET_REASON_AND_RETURN_IF_NEEDED(UnsupportedImageMap, reasons, includeReasons);
return reasons;
}
-#if !ALLOW_ALL_REPLACED
- SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
-#endif
return reasons;
}
-#endif
-#if ALLOW_INLINE_BLOCK
if (is<RenderBlockFlow>(child)) {
auto& block = downcast<RenderBlockFlow>(child);
if (!block.isReplaced() || !block.isInline())
@@ -579,9 +567,7 @@
return reasons;
}
-#endif
-#if ALLOW_INLINES
if (is<RenderInline>(child)) {
auto& renderInline = downcast<RenderInline>(child);
if (renderInline.isSVGInline())
@@ -615,7 +601,6 @@
return reasons;
}
-#endif
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
return reasons;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
