Title: [282948] branches/safari-612-branch
Revision
282948
Author
repst...@apple.com
Date
2021-09-22 22:50:37 -0700 (Wed, 22 Sep 2021)

Log Message

Cherry-pick r280705. rdar://problem/83430104

    VoiceOver is not announcing the state as selected/unselected when an item is selected in a grid.
    https://bugs.webkit.org/show_bug.cgi?id=228840
    <rdar://78225826>

    Reviewed by Chris Fleizach.

    Source/WebCore:

    Test: accessibility/selected-state-changed-notifications.html.

    On iOS, a table/grid cell element is not exposed to AX clients. Instead
    the content of the cell is. This patch ensures that if the cell element
    is selected, the AX objects that represent the content inside the cell
    will inherit the selected state from the cell.

    * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
    (-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):

    LayoutTests:

    * accessibility/selected-state-changed-notifications.html:
    * platform/ios/TestExpectations:
    * platform/ios/accessibility/selected-state-changed-notifications-expected.txt: Added.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-612-branch/LayoutTests/ChangeLog (282947 => 282948)


--- branches/safari-612-branch/LayoutTests/ChangeLog	2021-09-23 05:34:12 UTC (rev 282947)
+++ branches/safari-612-branch/LayoutTests/ChangeLog	2021-09-23 05:50:37 UTC (rev 282948)
@@ -1,5 +1,47 @@
 2021-09-22  Alan Coon  <alanc...@apple.com>
 
+        Cherry-pick r280705. rdar://problem/83430104
+
+    VoiceOver is not announcing the state as selected/unselected when an item is selected in a grid.
+    https://bugs.webkit.org/show_bug.cgi?id=228840
+    <rdar://78225826>
+    
+    Reviewed by Chris Fleizach.
+    
+    Source/WebCore:
+    
+    Test: accessibility/selected-state-changed-notifications.html.
+    
+    On iOS, a table/grid cell element is not exposed to AX clients. Instead
+    the content of the cell is. This patch ensures that if the cell element
+    is selected, the AX objects that represent the content inside the cell
+    will inherit the selected state from the cell.
+    
+    * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+    (-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
+    
+    LayoutTests:
+    
+    * accessibility/selected-state-changed-notifications.html:
+    * platform/ios/TestExpectations:
+    * platform/ios/accessibility/selected-state-changed-notifications-expected.txt: Added.
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-08-05  Andres Gonzalez  <andresg...@apple.com>
+
+            VoiceOver is not announcing the state as selected/unselected when an item is selected in a grid.
+            https://bugs.webkit.org/show_bug.cgi?id=228840
+            <rdar://78225826>
+
+            Reviewed by Chris Fleizach.
+
+            * accessibility/selected-state-changed-notifications.html:
+            * platform/ios/TestExpectations:
+            * platform/ios/accessibility/selected-state-changed-notifications-expected.txt: Added.
+
+2021-09-22  Alan Coon  <alanc...@apple.com>
+
         Cherry-pick r282369. rdar://problem/83429914
 
     AX: set insertion point to the end of a native text control does not work when passing a collapsed TextMarkerRange with both start and end equals to the end TextMarker for the element.

Modified: branches/safari-612-branch/LayoutTests/platform/ios/TestExpectations (282947 => 282948)


--- branches/safari-612-branch/LayoutTests/platform/ios/TestExpectations	2021-09-23 05:34:12 UTC (rev 282947)
+++ branches/safari-612-branch/LayoutTests/platform/ios/TestExpectations	2021-09-23 05:50:37 UTC (rev 282948)
@@ -3473,4 +3473,4 @@
 [ Release ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-connectionSetup.html [ Pass Failure ]
 [ Release ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html [ Pass Failure ]
 
-webkit.org/b/228200 editing/selection/ios/scrolling-to-focused-element-inside-iframe.html [ Failure ]
\ No newline at end of file
+webkit.org/b/228200 editing/selection/ios/scrolling-to-focused-element-inside-iframe.html [ Failure ]

Modified: branches/safari-612-branch/Source/WebCore/ChangeLog (282947 => 282948)


--- branches/safari-612-branch/Source/WebCore/ChangeLog	2021-09-23 05:34:12 UTC (rev 282947)
+++ branches/safari-612-branch/Source/WebCore/ChangeLog	2021-09-23 05:50:37 UTC (rev 282948)
@@ -1,5 +1,53 @@
 2021-09-22  Alan Coon  <alanc...@apple.com>
 
+        Cherry-pick r280705. rdar://problem/83430104
+
+    VoiceOver is not announcing the state as selected/unselected when an item is selected in a grid.
+    https://bugs.webkit.org/show_bug.cgi?id=228840
+    <rdar://78225826>
+    
+    Reviewed by Chris Fleizach.
+    
+    Source/WebCore:
+    
+    Test: accessibility/selected-state-changed-notifications.html.
+    
+    On iOS, a table/grid cell element is not exposed to AX clients. Instead
+    the content of the cell is. This patch ensures that if the cell element
+    is selected, the AX objects that represent the content inside the cell
+    will inherit the selected state from the cell.
+    
+    * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+    (-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
+    
+    LayoutTests:
+    
+    * accessibility/selected-state-changed-notifications.html:
+    * platform/ios/TestExpectations:
+    * platform/ios/accessibility/selected-state-changed-notifications-expected.txt: Added.
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-08-05  Andres Gonzalez  <andresg...@apple.com>
+
+            VoiceOver is not announcing the state as selected/unselected when an item is selected in a grid.
+            https://bugs.webkit.org/show_bug.cgi?id=228840
+            <rdar://78225826>
+
+            Reviewed by Chris Fleizach.
+
+            Test: accessibility/selected-state-changed-notifications.html.
+
+            On iOS, a table/grid cell element is not exposed to AX clients. Instead
+            the content of the cell is. This patch ensures that if the cell element
+            is selected, the AX objects that represent the content inside the cell
+            will inherit the selected state from the cell.
+
+            * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+            (-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
+
+2021-09-22  Alan Coon  <alanc...@apple.com>
+
         Cherry-pick r282047. rdar://problem/83430148
 
     Ensure fragmented flow state invalidation even when the cached fragmented flow is not present.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to