Title: [283287] trunk/Source
Revision
283287
Author
basuke.suz...@sony.com
Date
2021-09-29 17:21:20 -0700 (Wed, 29 Sep 2021)

Log Message

Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
https://bugs.webkit.org/show_bug.cgi?id=230963

Reviewed by Mark Lam.

Source/_javascript_Core:

Added default copy constructor to suppress warning.

* bytecode/Operands.h:

Source/WebCore:

No new tests because there is no behavior change.

Added default copy constructor / copy assignment operator to suppress warning.

* platform/LayoutUnit.h:
* platform/LengthBox.h:
* platform/RectEdges.h:
* platform/graphics/FontSelectionAlgorithm.h:
* platform/graphics/ImagePaintingOptions.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (283286 => 283287)


--- trunk/Source/_javascript_Core/ChangeLog	2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-09-30 00:21:20 UTC (rev 283287)
@@ -1,5 +1,16 @@
 2021-09-29  Basuke Suzuki  <basuke.suz...@sony.com>
 
+        Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
+        https://bugs.webkit.org/show_bug.cgi?id=230963
+
+        Reviewed by Mark Lam.
+
+        Added default copy constructor to suppress warning.
+
+        * bytecode/Operands.h:
+
+2021-09-29  Basuke Suzuki  <basuke.suz...@sony.com>
+
         [JSC] Add objectTypeCounts to JSGetMemoryUsageStatistics
         https://bugs.webkit.org/show_bug.cgi?id=230957
 

Modified: trunk/Source/_javascript_Core/bytecode/Operands.h (283286 => 283287)


--- trunk/Source/_javascript_Core/bytecode/Operands.h	2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/_javascript_Core/bytecode/Operands.h	2021-09-30 00:21:20 UTC (rev 283287)
@@ -68,6 +68,8 @@
     }
     static Operand tmp(uint32_t index) { return Operand(OperandKind::Tmp, index); }
 
+    Operand& operator=(const Operand&) = default;
+
     OperandKind kind() const { return m_kind; }
     int value() const { return m_operand; }
     VirtualRegister virtualRegister() const

Modified: trunk/Source/WebCore/ChangeLog (283286 => 283287)


--- trunk/Source/WebCore/ChangeLog	2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/ChangeLog	2021-09-30 00:21:20 UTC (rev 283287)
@@ -1,3 +1,20 @@
+2021-09-29  Basuke Suzuki  <basuke.suz...@sony.com>
+
+        Suppress warnings for implicit copy assignment operator/copy constructor with clang 13
+        https://bugs.webkit.org/show_bug.cgi?id=230963
+
+        Reviewed by Mark Lam.
+
+        No new tests because there is no behavior change.
+
+        Added default copy constructor / copy assignment operator to suppress warning.
+
+        * platform/LayoutUnit.h:
+        * platform/LengthBox.h:
+        * platform/RectEdges.h:
+        * platform/graphics/FontSelectionAlgorithm.h:
+        * platform/graphics/ImagePaintingOptions.h:
+
 2021-09-29  Kiet Ho  <th...@apple.com>
 
         Implement the 'ic' unit from CSS Values 4

Modified: trunk/Source/WebCore/platform/LayoutUnit.h (283286 => 283287)


--- trunk/Source/WebCore/platform/LayoutUnit.h	2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/LayoutUnit.h	2021-09-30 00:21:20 UTC (rev 283287)
@@ -65,6 +65,7 @@
 class LayoutUnit {
 public:
     LayoutUnit() : m_value(0) { }
+    LayoutUnit(const LayoutUnit&) = default;
     LayoutUnit(int value) { setValue(value); }
     LayoutUnit(unsigned short value) { setValue(value); }
     LayoutUnit(unsigned value) { setValue(value); }
@@ -85,7 +86,7 @@
         m_value = clampToInteger(value * kFixedPointDenominator);
     }
 
-    LayoutUnit& operator=(const LayoutUnit& other) = default;
+    LayoutUnit& operator=(const LayoutUnit&) = default;
     LayoutUnit& operator=(const float& other) { return *this = LayoutUnit(other); }
 
     static LayoutUnit fromFloatCeil(float value)

Modified: trunk/Source/WebCore/platform/LengthBox.h (283286 => 283287)


--- trunk/Source/WebCore/platform/LengthBox.h	2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/LengthBox.h	2021-09-30 00:21:20 UTC (rev 283287)
@@ -55,6 +55,7 @@
     }
 
     LengthBox(const LengthBox&) = default;
+    LengthBox& operator=(const LengthBox&) = default;
 
     bool isZero() const
     {

Modified: trunk/Source/WebCore/platform/RectEdges.h (283286 => 283287)


--- trunk/Source/WebCore/platform/RectEdges.h	2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/RectEdges.h	2021-09-30 00:21:20 UTC (rev 283287)
@@ -46,6 +46,7 @@
     RectEdges() = default;
 
     RectEdges(const RectEdges&) = default;
+    RectEdges& operator=(const RectEdges&) = default;
 
     template<typename U>
     RectEdges(U&& top, U&& right, U&& bottom, U&& left)

Modified: trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h (283286 => 283287)


--- trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h	2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/graphics/FontSelectionAlgorithm.h	2021-09-30 00:21:20 UTC (rev 283287)
@@ -426,6 +426,8 @@
 struct FontSelectionCapabilities {
     using Range = FontSelectionRange;
 
+    FontSelectionCapabilities() = default;
+    FontSelectionCapabilities(const FontSelectionCapabilities&) = default;
     FontSelectionCapabilities& operator=(const FontSelectionCapabilities&) = default;
 
     constexpr std::tuple<Range, Range, Range> tied() const

Modified: trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h (283286 => 283287)


--- trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h	2021-09-30 00:19:07 UTC (rev 283286)
+++ trunk/Source/WebCore/platform/graphics/ImagePaintingOptions.h	2021-09-30 00:21:20 UTC (rev 283287)
@@ -47,6 +47,7 @@
 
     ImagePaintingOptions() = default;
     ImagePaintingOptions(const ImagePaintingOptions&) = default;
+    ImagePaintingOptions& operator=(const ImagePaintingOptions&) = default;
 
     CompositeOperator compositeOperator() const { return m_compositeOperator; }
     BlendMode blendMode() const { return m_blendMode; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to