Title: [283315] trunk/Source
- Revision
- 283315
- Author
- you...@apple.com
- Date
- 2021-09-30 09:05:34 -0700 (Thu, 30 Sep 2021)
Log Message
Support AES GCM ciphers in WebRTC
https://bugs.webkit.org/show_bug.cgi?id=214402
<rdar://problem/65700381>
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
* Configurations/libwebrtc.iOS.exp:
* Configurations/libwebrtc.iOSsim.exp:
* Configurations/libwebrtc.mac.exp:
Source/WebCore:
Enable GCM ciphers in WebRTC as done by Chrome.
The default ciphers remain the same so use of these ciphers is opt-in by SFUs.
Manually tested.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::setConfiguration):
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (283314 => 283315)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-09-30 15:43:13 UTC (rev 283314)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-09-30 16:05:34 UTC (rev 283315)
@@ -1,3 +1,15 @@
+2021-09-30 Youenn Fablet <you...@apple.com>
+
+ Support AES GCM ciphers in WebRTC
+ https://bugs.webkit.org/show_bug.cgi?id=214402
+ <rdar://problem/65700381>
+
+ Reviewed by Eric Carlson.
+
+ * Configurations/libwebrtc.iOS.exp:
+ * Configurations/libwebrtc.iOSsim.exp:
+ * Configurations/libwebrtc.mac.exp:
+
2021-09-28 Alex Christensen <achristen...@webkit.org>
Mostly fix Mac CMake build
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp (283314 => 283315)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp 2021-09-30 15:43:13 UTC (rev 283314)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp 2021-09-30 16:05:34 UTC (rev 283315)
@@ -327,3 +327,4 @@
__ZN3rtc12SSLCertChainD1Ev
__ZN6webrtc24SctpTransportInformationD1Ev
__ZNK3rtc9IPAddressneERKS0_
+__ZN6webrtc13CryptoOptionsC1Ev
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp (283314 => 283315)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp 2021-09-30 15:43:13 UTC (rev 283314)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp 2021-09-30 16:05:34 UTC (rev 283315)
@@ -327,3 +327,4 @@
__ZN3rtc12SSLCertChainD1Ev
__ZN6webrtc24SctpTransportInformationD1Ev
__ZNK3rtc9IPAddressneERKS0_
+__ZN6webrtc13CryptoOptionsC1Ev
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp (283314 => 283315)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp 2021-09-30 15:43:13 UTC (rev 283314)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp 2021-09-30 16:05:34 UTC (rev 283315)
@@ -327,3 +327,4 @@
__ZN3rtc12SSLCertChainD1Ev
__ZN6webrtc24SctpTransportInformationD1Ev
__ZNK3rtc9IPAddressneERKS0_
+__ZN6webrtc13CryptoOptionsC1Ev
Modified: trunk/Source/WebCore/ChangeLog (283314 => 283315)
--- trunk/Source/WebCore/ChangeLog 2021-09-30 15:43:13 UTC (rev 283314)
+++ trunk/Source/WebCore/ChangeLog 2021-09-30 16:05:34 UTC (rev 283315)
@@ -1,3 +1,19 @@
+2021-09-30 Youenn Fablet <you...@apple.com>
+
+ Support AES GCM ciphers in WebRTC
+ https://bugs.webkit.org/show_bug.cgi?id=214402
+ <rdar://problem/65700381>
+
+ Reviewed by Eric Carlson.
+
+ Enable GCM ciphers in WebRTC as done by Chrome.
+ The default ciphers remain the same so use of these ciphers is opt-in by SFUs.
+
+ Manually tested.
+
+ * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+ (WebCore::LibWebRTCMediaEndpoint::setConfiguration):
+
2021-09-30 Alan Bujtas <za...@apple.com>
[LFC][IFC] RootInlineBox should use the first-line style when applicable
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (283314 => 283315)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2021-09-30 15:43:13 UTC (rev 283314)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2021-09-30 16:05:34 UTC (rev 283315)
@@ -92,6 +92,8 @@
bool LibWebRTCMediaEndpoint::setConfiguration(LibWebRTCProvider& client, webrtc::PeerConnectionInterface::RTCConfiguration&& configuration)
{
configuration.sdp_semantics = webrtc::SdpSemantics::kUnifiedPlan;
+ configuration.crypto_options = webrtc::CryptoOptions { };
+ configuration.crypto_options->srtp.enable_gcm_crypto_suites = true;
if (!m_backend) {
auto& document = downcast<Document>(*m_peerConnectionBackend.connection().scriptExecutionContext());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
