Title: [283348] trunk
- Revision
- 283348
- Author
- ysuz...@apple.com
- Date
- 2021-09-30 17:26:28 -0700 (Thu, 30 Sep 2021)
Log Message
Upgrade GCC requirement to 8.3.0
https://bugs.webkit.org/show_bug.cgi?id=231042
Reviewed by Darin Adler.
.:
Based on the roadmap[1], we upgrade GCC requirement to 8.3.0, which is default GCC in Debian one-old-stable (buster) right now.
This paves the way to enabling some of useful C++20 features, e.g. default initializer for bitfields.
[1]: https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement
* Source/cmake/WebKitCommon.cmake:
Source/_javascript_Core:
* runtime/ConfigFile.cpp:
(JSC::ConfigFile::canonicalizePaths):
Modified Paths
Diff
Modified: trunk/ChangeLog (283347 => 283348)
--- trunk/ChangeLog 2021-09-30 23:38:32 UTC (rev 283347)
+++ trunk/ChangeLog 2021-10-01 00:26:28 UTC (rev 283348)
@@ -1,3 +1,17 @@
+2021-09-30 Yusuke Suzuki <ysuz...@apple.com>
+
+ Upgrade GCC requirement to 8.3.0
+ https://bugs.webkit.org/show_bug.cgi?id=231042
+
+ Reviewed by Darin Adler.
+
+ Based on the roadmap[1], we upgrade GCC requirement to 8.3.0, which is default GCC in Debian one-old-stable (buster) right now.
+ This paves the way to enabling some of useful C++20 features, e.g. default initializer for bitfields.
+
+ [1]: https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement
+
+ * Source/cmake/WebKitCommon.cmake:
+
2021-09-29 Kimmo Kinnunen <kkinnu...@apple.com>
MediaStream canvas.captureStream() fails for WebGL
Modified: trunk/Source/_javascript_Core/ChangeLog (283347 => 283348)
--- trunk/Source/_javascript_Core/ChangeLog 2021-09-30 23:38:32 UTC (rev 283347)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-01 00:26:28 UTC (rev 283348)
@@ -1,3 +1,13 @@
+2021-09-30 Yusuke Suzuki <ysuz...@apple.com>
+
+ Upgrade GCC requirement to 8.3.0
+ https://bugs.webkit.org/show_bug.cgi?id=231042
+
+ Reviewed by Darin Adler.
+
+ * runtime/ConfigFile.cpp:
+ (JSC::ConfigFile::canonicalizePaths):
+
2021-09-30 Saam Barati <sbar...@apple.com>
Regressions (r283288): [ macOS Debug ] webgl/2.0.0/conformance/state/gl-object-get-calls.html is timing out
Modified: trunk/Source/_javascript_Core/runtime/ConfigFile.cpp (283347 => 283348)
--- trunk/Source/_javascript_Core/runtime/ConfigFile.cpp 2021-09-30 23:38:32 UTC (rev 283347)
+++ trunk/Source/_javascript_Core/runtime/ConfigFile.cpp 2021-10-01 00:26:28 UTC (rev 283348)
@@ -487,17 +487,9 @@
if (sizeof(filenameBuffer) - 1 >= pathnameLength + shouldAddPathSeparator) {
if (shouldAddPathSeparator)
strncat(filenameBuffer, "/", 2); // Room for '/' plus NUL
-#if COMPILER(GCC)
-#if GCC_VERSION_AT_LEAST(8, 0, 0)
- IGNORE_WARNINGS_BEGIN("stringop-truncation")
-#endif
-#endif
+ IGNORE_GCC_WARNINGS_BEGIN("stringop-truncation")
strncat(filenameBuffer, m_filename, sizeof(filenameBuffer) - strlen(filenameBuffer) - 1);
-#if COMPILER(GCC)
-#if GCC_VERSION_AT_LEAST(8, 0, 0)
- IGNORE_WARNINGS_END
-#endif
-#endif
+ IGNORE_GCC_WARNINGS_END
strncpy(m_filename, filenameBuffer, s_maxPathLength);
m_filename[s_maxPathLength] = '\0';
}
Modified: trunk/Source/cmake/WebKitCommon.cmake (283347 => 283348)
--- trunk/Source/cmake/WebKitCommon.cmake 2021-09-30 23:38:32 UTC (rev 283347)
+++ trunk/Source/cmake/WebKitCommon.cmake 2021-10-01 00:26:28 UTC (rev 283348)
@@ -63,8 +63,8 @@
endif ()
if (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU")
- if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "7.3.0")
- message(FATAL_ERROR "GCC 7.3 or newer is required to build WebKit. Use a newer GCC version or Clang.")
+ if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "8.3.0")
+ message(FATAL_ERROR "GCC 8.3 or newer is required to build WebKit. Use a newer GCC version or Clang.")
endif ()
endif ()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
