Title: [284329] trunk/Source/WebKit
- Revision
- 284329
- Author
- ddkil...@apple.com
- Date
- 2021-10-16 20:58:51 -0700 (Sat, 16 Oct 2021)
Log Message
_WKRemoteWebInspectorViewController leaks an instance variable and should use a weak delegate
<https://webkit.org/b/231830>
<rdar://problem/84316056>
Reviewed by Brent Fulgham.
* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
- Use a weak reference for the delegate.
* UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
(-[_WKRemoteWebInspectorViewController dealloc]): Add.
- Fix leak by releasing _configuration instance variable.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (284328 => 284329)
--- trunk/Source/WebKit/ChangeLog 2021-10-16 23:41:39 UTC (rev 284328)
+++ trunk/Source/WebKit/ChangeLog 2021-10-17 03:58:51 UTC (rev 284329)
@@ -1,3 +1,17 @@
+2021-10-16 David Kilzer <ddkil...@apple.com>
+
+ _WKRemoteWebInspectorViewController leaks an instance variable and should use a weak delegate
+ <https://webkit.org/b/231830>
+ <rdar://problem/84316056>
+
+ Reviewed by Brent Fulgham.
+
+ * UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
+ - Use a weak reference for the delegate.
+ * UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
+ (-[_WKRemoteWebInspectorViewController dealloc]): Add.
+ - Fix leak by releasing _configuration instance variable.
+
2021-10-16 Tim Horton <timothy_hor...@apple.com>
WebKit ignores inherited GCC_PREPROCESSOR_DEFINITIONS
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h (284328 => 284329)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h 2021-10-16 23:41:39 UTC (rev 284328)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h 2021-10-17 03:58:51 UTC (rev 284329)
@@ -40,7 +40,7 @@
WK_CLASS_AVAILABLE(macos(10.12.3))
@interface _WKRemoteWebInspectorViewController : NSObject <_WKInspectorExtensionHost, _WKInspectorIBActions>
-@property (nonatomic, assign) id <_WKRemoteWebInspectorViewControllerDelegate> delegate;
+@property (nonatomic, weak) id <_WKRemoteWebInspectorViewControllerDelegate> delegate;
@property (nonatomic, readonly, retain) NSWindow *window;
@property (nonatomic, readonly, retain) WKWebView *webView;
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm (284328 => 284329)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm 2021-10-16 23:41:39 UTC (rev 284328)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm 2021-10-17 03:58:51 UTC (rev 284329)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2016-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -105,6 +105,12 @@
return self;
}
+- (void)dealloc
+{
+ [_configuration release];
+ [super dealloc];
+}
+
- (NSWindow *)window
{
return m_remoteInspectorProxy->window();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
