Title: [284638] trunk/Tools
- Revision
- 284638
- Author
- hironori.fu...@sony.com
- Date
- 2021-10-21 13:21:01 -0700 (Thu, 21 Oct 2021)
Log Message
[Win] TestWTF.FileSystemTest.* are timing out if run-api-tests is run by a normal user
https://bugs.webkit.org/show_bug.cgi?id=232065
Reviewed by Jonathan Bedard.
run-api-tests script didn't pass TEMP and TMP env vars to
TestWTF.exe. Then, generateTemporaryPath in
wtf/win/FileSystemWin.cpp never finished because a normal user
can't create a file in the Windows system directory.
* Scripts/webkitpy/port/win.py:
(WinPort.environment_for_api_tests): Added TEMP and TMP to the env
var list to inherit.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (284637 => 284638)
--- trunk/Tools/ChangeLog 2021-10-21 20:17:08 UTC (rev 284637)
+++ trunk/Tools/ChangeLog 2021-10-21 20:21:01 UTC (rev 284638)
@@ -1,5 +1,21 @@
2021-10-21 Fujii Hironori <hironori.fu...@sony.com>
+ [Win] TestWTF.FileSystemTest.* are timing out if run-api-tests is run by a normal user
+ https://bugs.webkit.org/show_bug.cgi?id=232065
+
+ Reviewed by Jonathan Bedard.
+
+ run-api-tests script didn't pass TEMP and TMP env vars to
+ TestWTF.exe. Then, generateTemporaryPath in
+ wtf/win/FileSystemWin.cpp never finished because a normal user
+ can't create a file in the Windows system directory.
+
+ * Scripts/webkitpy/port/win.py:
+ (WinPort.environment_for_api_tests): Added TEMP and TMP to the env
+ var list to inherit.
+
+2021-10-21 Fujii Hironori <hironori.fu...@sony.com>
+
[Win Python] REGRESSION(r284398): run-api-tests: FileNotFoundError raised: [WinError 2] The system cannot find the file specified
https://bugs.webkit.org/show_bug.cgi?id=232037
Modified: trunk/Tools/Scripts/webkitpy/port/win.py (284637 => 284638)
--- trunk/Tools/Scripts/webkitpy/port/win.py 2021-10-21 20:17:08 UTC (rev 284637)
+++ trunk/Tools/Scripts/webkitpy/port/win.py 2021-10-21 20:21:01 UTC (rev 284638)
@@ -142,7 +142,13 @@
def environment_for_api_tests(self):
env = super(WinPort, self).environment_for_api_tests()
- for variable in ['SYSTEMROOT', 'WEBKIT_LIBRARIES']:
+ variables_to_copy = [
+ 'SYSTEMROOT',
+ 'TEMP',
+ 'TMP',
+ 'WEBKIT_LIBRARIES',
+ ]
+ for variable in variables_to_copy:
self._copy_value_from_environ_if_set(env, variable)
return env
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
