Title: [284867] trunk
- Revision
- 284867
- Author
- commit-qu...@webkit.org
- Date
- 2021-10-26 08:23:12 -0700 (Tue, 26 Oct 2021)
Log Message
REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=231061
<rdar://problem/84012523>
Patch by Philippe Normand <pnorm...@igalia.com> on 2021-10-26
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Implement WebGL canvas sampling for GStreamer ports.
* platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample):
LayoutTests:
* platform/glib/TestExpectations: Test is passing now. Unflag.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (284866 => 284867)
--- trunk/LayoutTests/ChangeLog 2021-10-26 15:04:13 UTC (rev 284866)
+++ trunk/LayoutTests/ChangeLog 2021-10-26 15:23:12 UTC (rev 284867)
@@ -1,3 +1,13 @@
+2021-10-26 Philippe Normand <pnorm...@igalia.com>
+
+ REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=231061
+ <rdar://problem/84012523>
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/glib/TestExpectations: Test is passing now. Unflag.
+
2021-10-26 Antti Koivisto <an...@apple.com>
Fix ::part(foo):hover
Modified: trunk/LayoutTests/platform/glib/TestExpectations (284866 => 284867)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-10-26 15:04:13 UTC (rev 284866)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-10-26 15:23:12 UTC (rev 284867)
@@ -680,7 +680,6 @@
webkit.org/b/79203 fast/mediastream/RTCRtpSender-replaceTrack.html [ Failure ]
webkit.org/b/187603 fast/mediastream/media-stream-track-source-failure.html [ Timeout Failure Pass ]
webkit.org/b/231057 fast/mediastream/media-stream-video-track-interrupted.html [ Failure ]
-webkit.org/b/231061 fast/mediastream/captureStream/canvas3d.html [ Timeout ]
webkit.org/b/223508 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html [ Failure Pass ]
Modified: trunk/Source/WebCore/ChangeLog (284866 => 284867)
--- trunk/Source/WebCore/ChangeLog 2021-10-26 15:04:13 UTC (rev 284866)
+++ trunk/Source/WebCore/ChangeLog 2021-10-26 15:23:12 UTC (rev 284867)
@@ -1,3 +1,16 @@
+2021-10-26 Philippe Normand <pnorm...@igalia.com>
+
+ REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=231061
+ <rdar://problem/84012523>
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Implement WebGL canvas sampling for GStreamer ports.
+
+ * platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
+ (WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample):
+
2021-10-26 Antti Koivisto <an...@apple.com>
Fix ::part(foo):hover
Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp (284866 => 284867)
--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp 2021-10-26 15:04:13 UTC (rev 284866)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp 2021-10-26 15:23:12 UTC (rev 284867)
@@ -45,6 +45,10 @@
#include "MediaSample.h"
#endif
+#if USE(GSTREAMER) && ENABLE(MEDIA_STREAM)
+#include "MediaSampleGStreamer.h"
+#endif
+
namespace WebCore {
#if !PLATFORM(COCOA)
@@ -186,6 +190,10 @@
#if !PLATFORM(COCOA) && ENABLE(MEDIA_STREAM)
RefPtr<MediaSample> GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample()
{
+#if USE(GSTREAMER)
+ if (auto pixelBuffer = readCompositedResults())
+ return MediaSampleGStreamer::createImageSample(WTFMove(*pixelBuffer));
+#endif
return nullptr;
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
