Title: [284891] trunk/Tools
- Revision
- 284891
- Author
- simon.fra...@apple.com
- Date
- 2021-10-26 12:51:18 -0700 (Tue, 26 Oct 2021)
Log Message
The script should decide when an image diff cases, not ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=232225
Unreviewed; respond to review feedback.
* Scripts/webkitpy/port/image_diff.py:
(ImageDiffer._read):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (284890 => 284891)
--- trunk/Tools/ChangeLog 2021-10-26 19:50:30 UTC (rev 284890)
+++ trunk/Tools/ChangeLog 2021-10-26 19:51:18 UTC (rev 284891)
@@ -1,3 +1,13 @@
+2021-10-26 Simon Fraser <simon.fra...@apple.com>
+
+ The script should decide when an image diff cases, not ImageDiff
+ https://bugs.webkit.org/show_bug.cgi?id=232225
+
+ Unreviewed; respond to review feedback.
+
+ * Scripts/webkitpy/port/image_diff.py:
+ (ImageDiffer._read):
+
2021-10-26 Alex Christensen <achristen...@webkit.org>
Update PCM test public key to one with RSA-PSS OID
Modified: trunk/Tools/Scripts/webkitpy/port/image_diff.py (284890 => 284891)
--- trunk/Tools/Scripts/webkitpy/port/image_diff.py 2021-10-26 19:50:30 UTC (rev 284890)
+++ trunk/Tools/Scripts/webkitpy/port/image_diff.py 2021-10-26 19:51:18 UTC (rev 284891)
@@ -134,7 +134,7 @@
m = re.match(b'diff: (.+)%', diff_output)
if not m:
- return ImageDiffResult(passed=False, diff_image=None, difference=0, tolerance=self._tolerance, error_string=err_str or "Failed to match ImageDiff output %s" % diff_output)
+ return ImageDiffResult(passed=False, diff_image=None, difference=0, tolerance=self._tolerance, error_string=err_str or 'Failed to match ImageDiff output {}'.format(diff_output))
diff_percent = float(string_utils.decode(m.group(1), target_type=str))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
