Title: [284996] trunk
- Revision
- 284996
- Author
- nmouchta...@apple.com
- Date
- 2021-10-28 13:22:21 -0700 (Thu, 28 Oct 2021)
Log Message
[Debug] imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.ellipse.basics.html is asserting
https://bugs.webkit.org/show_bug.cgi?id=218671
Reviewed by Simon Fraser.
Source/WebCore:
Add extra check to assert that was failing due to floating point precision error.
* html/canvas/CanvasPath.cpp:
(WebCore::normalizeAngles):
LayoutTests:
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (284995 => 284996)
--- trunk/LayoutTests/ChangeLog 2021-10-28 19:55:48 UTC (rev 284995)
+++ trunk/LayoutTests/ChangeLog 2021-10-28 20:22:21 UTC (rev 284996)
@@ -1,3 +1,12 @@
+2021-10-28 Nikolaos Mouchtaris <nmouchta...@apple.com>
+
+ [Debug] imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.ellipse.basics.html is asserting
+ https://bugs.webkit.org/show_bug.cgi?id=218671
+
+ Reviewed by Simon Fraser.
+
+ * TestExpectations:
+
2021-10-28 Eric Hutchison <ehutchi...@apple.com>
[ Catalina Debug wk1 EWS ] media/track/track-element-dom-change-crash.html is a flaky crash.
Modified: trunk/LayoutTests/TestExpectations (284995 => 284996)
--- trunk/LayoutTests/TestExpectations 2021-10-28 19:55:48 UTC (rev 284995)
+++ trunk/LayoutTests/TestExpectations 2021-10-28 20:22:21 UTC (rev 284996)
@@ -327,9 +327,6 @@
imported/w3c/web-platform-tests/selection/collapse-30.html [ Skip ]
imported/w3c/web-platform-tests/selection/dir-manual.html [ Skip ]
-# This test has been crashing in Debug since its import.
-webkit.org/b/218671 [ Debug ] imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.ellipse.basics.html [ Skip ]
-
# Newly imported service worker tests that are timing out.
imported/w3c/web-platform-tests/service-workers/service-worker/dedicated-worker-service-worker-interception.https.html [ Skip ]
webkit.org/b/201665 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video.https.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (284995 => 284996)
--- trunk/Source/WebCore/ChangeLog 2021-10-28 19:55:48 UTC (rev 284995)
+++ trunk/Source/WebCore/ChangeLog 2021-10-28 20:22:21 UTC (rev 284996)
@@ -1,3 +1,15 @@
+2021-10-28 Nikolaos Mouchtaris <nmouchta...@apple.com>
+
+ [Debug] imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.ellipse.basics.html is asserting
+ https://bugs.webkit.org/show_bug.cgi?id=218671
+
+ Reviewed by Simon Fraser.
+
+ Add extra check to assert that was failing due to floating point precision error.
+
+ * html/canvas/CanvasPath.cpp:
+ (WebCore::normalizeAngles):
+
2021-10-28 Tim Horton <timothy_hor...@apple.com>
DOM GPUP: Yahoo.com has fragments of wrongly-scaled content throughout
Modified: trunk/Source/WebCore/html/canvas/CanvasPath.cpp (284995 => 284996)
--- trunk/Source/WebCore/html/canvas/CanvasPath.cpp 2021-10-28 19:55:48 UTC (rev 284995)
+++ trunk/Source/WebCore/html/canvas/CanvasPath.cpp 2021-10-28 20:22:21 UTC (rev 284996)
@@ -145,7 +145,7 @@
float delta = newStartAngle - startAngle;
startAngle = newStartAngle;
endAngle = endAngle + delta;
- ASSERT(newStartAngle >= 0 && newStartAngle < 2 * piFloat);
+ ASSERT(newStartAngle >= 0 && (newStartAngle < 2 * piFloat || WTF::areEssentiallyEqual<float>(newStartAngle, 2 * piFloat)));
if (anticlockwise && startAngle - endAngle >= 2 * piFloat)
endAngle = startAngle - 2 * piFloat;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
