Title: [285001] trunk/Source/WebKit
- Revision
- 285001
- Author
- commit-qu...@webkit.org
- Date
- 2021-10-28 14:01:00 -0700 (Thu, 28 Oct 2021)
Log Message
[WPE][GTK] Add warning comments regarding use of child setup functions
https://bugs.webkit.org/show_bug.cgi?id=232444
Patch by Michael Catanzaro <mcatanz...@gnome.org> on 2021-10-28
Reviewed by Adrian Perez de Castro.
* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::XDGDBusProxyLauncher::launch):
* UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (285000 => 285001)
--- trunk/Source/WebKit/ChangeLog 2021-10-28 20:57:59 UTC (rev 285000)
+++ trunk/Source/WebKit/ChangeLog 2021-10-28 21:01:00 UTC (rev 285001)
@@ -1,3 +1,15 @@
+2021-10-28 Michael Catanzaro <mcatanz...@gnome.org>
+
+ [WPE][GTK] Add warning comments regarding use of child setup functions
+ https://bugs.webkit.org/show_bug.cgi?id=232444
+
+ Reviewed by Adrian Perez de Castro.
+
+ * UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+ (WebKit::XDGDBusProxyLauncher::launch):
+ * UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
+ (WebKit::ProcessLauncher::launchProcess):
+
2021-10-28 Adrian Perez de Castro <ape...@igalia.com>
[WPE][Qt] Do not use WebKit internals in the implementation
Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (285000 => 285001)
--- trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp 2021-10-28 20:57:59 UTC (rev 285000)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp 2021-10-28 21:01:00 UTC (rev 285001)
@@ -248,6 +248,9 @@
argv[i++] = const_cast<char*>(arg.data());
argv[i] = nullptr;
+ // Warning: do not set a child setup function, because we want GIO to be able to spawn with
+ // posix_spawn() rather than fork()/exec(), in order to better accomodate applications that use
+ // a huge amount of memory or address space in the UI process, like Eclipse.
GRefPtr<GSubprocessLauncher> launcher = adoptGRef(g_subprocess_launcher_new(G_SUBPROCESS_FLAGS_INHERIT_FDS));
g_subprocess_launcher_take_fd(launcher.get(), proxyFd, proxyFd);
g_subprocess_launcher_take_fd(launcher.get(), syncFds[1], syncFds[1]);
Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp (285000 => 285001)
--- trunk/Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp 2021-10-28 20:57:59 UTC (rev 285000)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp 2021-10-28 21:01:00 UTC (rev 285001)
@@ -123,6 +123,9 @@
#endif
argv[i++] = nullptr;
+ // Warning: do not set a child setup function, because we want GIO to be able to spawn with
+ // posix_spawn() rather than fork()/exec(), in order to better accomodate applications that use
+ // a huge amount of memory or address space in the UI process, like Eclipse.
GRefPtr<GSubprocessLauncher> launcher = adoptGRef(g_subprocess_launcher_new(G_SUBPROCESS_FLAGS_INHERIT_FDS));
g_subprocess_launcher_take_fd(launcher.get(), socketPair.client, socketPair.client);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
