Title: [285018] trunk/Source/WebKitLegacy/mac
- Revision
- 285018
- Author
- pvol...@apple.com
- Date
- 2021-10-28 21:19:00 -0700 (Thu, 28 Oct 2021)
Log Message
Layout test is crashing inside WebChromeClient::createWindow
https://bugs.webkit.org/show_bug.cgi?id=232460
<rdar://81344393>
Reviewed by Brent Fulgham.
Add null check for local NetscapePluginHostProxy pointer variable.
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::didCreateWindow):
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (285017 => 285018)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-10-29 03:49:24 UTC (rev 285017)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-10-29 04:19:00 UTC (rev 285018)
@@ -1,3 +1,16 @@
+2021-10-28 Per Arne Vollan <pvol...@apple.com>
+
+ Layout test is crashing inside WebChromeClient::createWindow
+ https://bugs.webkit.org/show_bug.cgi?id=232460
+ <rdar://81344393>
+
+ Reviewed by Brent Fulgham.
+
+ Add null check for local NetscapePluginHostProxy pointer variable.
+
+ * Plugins/Hosted/NetscapePluginHostManager.mm:
+ (WebKit::NetscapePluginHostManager::didCreateWindow):
+
2021-10-28 Alex Christensen <achristen...@webkit.org>
Disable NETSCAPE_PLUGIN_API at build time on macOS and Windows
Modified: trunk/Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostManager.mm (285017 => 285018)
--- trunk/Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostManager.mm 2021-10-29 03:49:24 UTC (rev 285017)
+++ trunk/Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostManager.mm 2021-10-29 04:19:00 UTC (rev 285018)
@@ -311,7 +311,12 @@
PluginHostMap::iterator end = m_pluginHosts.end();
for (PluginHostMap::iterator it = m_pluginHosts.begin(); it != end; ++it) {
NetscapePluginHostProxy* hostProxy = it->value;
-
+
+ if (!hostProxy) {
+ LOG_ERROR("Could not find a NetscapePluginHostProxy for key %s.", it->key.utf8().data());
+ continue;
+ }
+
if (!hostProxy->isMenuBarVisible()) {
// Make ourselves the front process.
ProcessSerialNumber psn;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
