Title: [285106] trunk/LayoutTests
Revision
285106
Author
cdu...@apple.com
Date
2021-11-01 08:55:19 -0700 (Mon, 01 Nov 2021)

Log Message

REGRESSION (r283935): fast/css/style-element-process-crash.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=232456
<rdar://problem/84779240>

Reviewed by Wenson Hsieh.

After r283935, focus may happen asynchronously when using autofocus. As a result, we need to
update the test to use waitUntilDone() / notifyDone().

* fast/css/style-element-process-crash.html:
* platform/ios-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (285105 => 285106)


--- trunk/LayoutTests/ChangeLog	2021-11-01 15:52:33 UTC (rev 285105)
+++ trunk/LayoutTests/ChangeLog	2021-11-01 15:55:19 UTC (rev 285106)
@@ -1,3 +1,17 @@
+2021-11-01  Chris Dumez  <cdu...@apple.com>
+
+        REGRESSION (r283935): fast/css/style-element-process-crash.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=232456
+        <rdar://problem/84779240>
+
+        Reviewed by Wenson Hsieh.
+
+        After r283935, focus may happen asynchronously when using autofocus. As a result, we need to
+        update the test to use waitUntilDone() / notifyDone().
+
+        * fast/css/style-element-process-crash.html:
+        * platform/ios-wk2/TestExpectations:
+
 2021-10-31  Fujii Hironori  <hironori.fu...@sony.com>
 
         [WinCairo] Unreviewed test gardening

Modified: trunk/LayoutTests/fast/css/style-element-process-crash.html (285105 => 285106)


--- trunk/LayoutTests/fast/css/style-element-process-crash.html	2021-11-01 15:52:33 UTC (rev 285105)
+++ trunk/LayoutTests/fast/css/style-element-process-crash.html	2021-11-01 15:55:19 UTC (rev 285106)
@@ -1,11 +1,15 @@
 <!DOCTYPE html>
 <html>
 <script>
-if (window.testRunner)
-	testRunner.dumpAsText();
+if (window.testRunner) {
+    testRunner.dumpAsText();
+    testRunner.waitUntilDone();
+}
 
 function crash() {
-	document.body.innerHTML = "PASS. WebKit didn't crash.";
+    document.body.innerHTML = "PASS. WebKit didn't crash.";
+    if (window.testRunner)
+        testRunner.notifyDone();
 }
 </script>
 <object>
@@ -13,7 +17,7 @@
 </object>
 <style>
 .abc::first-child { 
-	font: 2147483647 small-caps 3507521020px sans-serif;
+    font: 2147483647 small-caps 3507521020px sans-serif;
 }
 </style>
 </html>

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (285105 => 285106)


--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-11-01 15:52:33 UTC (rev 285105)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-11-01 15:55:19 UTC (rev 285106)
@@ -2249,5 +2249,3 @@
 
 webkit.org/b/232337 [ Release ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-coop-navigated-opener.https.html [ Pass Failure  DumpJSConsoleLogInStdErr ]
 
-webkit.org/b/232456 fast/css/style-element-process-crash.html [ Pass Failure ]
-
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to