Title: [285200] trunk/LayoutTests
Revision
285200
Author
commit-qu...@webkit.org
Date
2021-11-03 01:23:50 -0700 (Wed, 03 Nov 2021)

Log Message

REGRESSION(r284603) [GTK][WPE] test fast/frames/flattening/scrolling-in-object.html fails
https://bugs.webkit.org/show_bug.cgi?id=232627

Use UIHelper.waitForTargetScrollAnimationToSettle rather than a timeout to make the test reliable.

Patch by Arcady Goldmints-Orlov <agoldmi...@igalia.com> on 2021-11-03
Reviewed by Martin Robinson.

* fast/frames/flattening/scrolling-in-object.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (285199 => 285200)


--- trunk/LayoutTests/ChangeLog	2021-11-03 06:53:13 UTC (rev 285199)
+++ trunk/LayoutTests/ChangeLog	2021-11-03 08:23:50 UTC (rev 285200)
@@ -1,3 +1,14 @@
+2021-11-03  Arcady Goldmints-Orlov  <agoldmi...@igalia.com>
+
+        REGRESSION(r284603) [GTK][WPE] test fast/frames/flattening/scrolling-in-object.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=232627
+
+        Use UIHelper.waitForTargetScrollAnimationToSettle rather than a timeout to make the test reliable.
+
+        Reviewed by Martin Robinson.
+
+        * fast/frames/flattening/scrolling-in-object.html:
+
 2021-11-02  Gabriel Nava Marino  <gnavamar...@apple.com>
 
         Crash in RenderLayer::rebuildZOrderLists

Modified: trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html (285199 => 285200)


--- trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html	2021-11-03 06:53:13 UTC (rev 285199)
+++ trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html	2021-11-03 08:23:50 UTC (rev 285200)
@@ -1,12 +1,14 @@
 <html>
     <head>
+        <script src=""
         <script type="text/_javascript_">
+            window.jsTestIsAsync = true;
             if (window.testRunner && window.internals) {
                 testRunner.waitUntilDone();
                 internals.settings.setFrameFlattening("FullyEnabled")
             }
 
-            function runTest()
+            async function runTest()
             {
                 if (window.eventSender && window.testRunner) {
                     var element = document.getElementById('targetObject');
@@ -14,9 +16,8 @@
                     var startY = element.offsetTop + element.offsetHeight / 2;
                     eventSender.mouseMoveTo(startX, startY);
                     eventSender.mouseScrollBy(0, -4);
-                    setTimeout(function() {
-                        testRunner.notifyDone();
-                    }, 100);
+                    await UIHelper.waitForTargetScrollAnimationToSettle(element);
+                    testRunner.notifyDone();
                 }
             }
         </script>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to