Title: [285203] trunk/LayoutTests
- Revision
- 285203
- Author
- n...@apple.com
- Date
- 2021-11-03 05:45:37 -0700 (Wed, 03 Nov 2021)
Log Message
Make render-layer-rebuild-z-order-lists.html use an HTML reference
https://bugs.webkit.org/show_bug.cgi?id=232658
Reviewed by Antti Koivisto.
This not only tests the crash, but also tests that the dialog is rendered (which was not
the case at the first iteration of the patch which introduced this test).
Also done some minor cleanups to the test.
* fast/layers/render-layer-rebuild-z-order-lists-expected.html: Added.
* fast/layers/render-layer-rebuild-z-order-lists-expected.txt: Removed.
* fast/layers/render-layer-rebuild-z-order-lists.html:
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (285202 => 285203)
--- trunk/LayoutTests/ChangeLog 2021-11-03 10:59:18 UTC (rev 285202)
+++ trunk/LayoutTests/ChangeLog 2021-11-03 12:45:37 UTC (rev 285203)
@@ -1,3 +1,19 @@
+2021-11-03 Tim Nguyen <n...@apple.com>
+
+ Make render-layer-rebuild-z-order-lists.html use an HTML reference
+ https://bugs.webkit.org/show_bug.cgi?id=232658
+
+ Reviewed by Antti Koivisto.
+
+ This not only tests the crash, but also tests that the dialog is rendered (which was not
+ the case at the first iteration of the patch which introduced this test).
+
+ Also done some minor cleanups to the test.
+
+ * fast/layers/render-layer-rebuild-z-order-lists-expected.html: Added.
+ * fast/layers/render-layer-rebuild-z-order-lists-expected.txt: Removed.
+ * fast/layers/render-layer-rebuild-z-order-lists.html:
+
2021-11-03 Arcady Goldmints-Orlov <agoldmi...@igalia.com>
REGRESSION(r284603) [GTK][WPE] test fast/frames/flattening/scrolling-in-object.html fails
Added: trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.html (0 => 285203)
--- trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.html (rev 0)
+++ trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.html 2021-11-03 12:45:37 UTC (rev 285203)
@@ -0,0 +1,4 @@
+<dialog>PASS if this displays and doesn't crash</dialog>
+<script>
+document.querySelector("dialog").showModal();
+</script>
\ No newline at end of file
Deleted: trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.txt (285202 => 285203)
--- trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.txt 2021-11-03 10:59:18 UTC (rev 285202)
+++ trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists-expected.txt 2021-11-03 12:45:37 UTC (rev 285203)
@@ -1 +0,0 @@
-PASS if this doesn't crash
Modified: trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists.html (285202 => 285203)
--- trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists.html 2021-11-03 10:59:18 UTC (rev 285202)
+++ trunk/LayoutTests/fast/layers/render-layer-rebuild-z-order-lists.html 2021-11-03 12:45:37 UTC (rev 285203)
@@ -7,16 +7,13 @@
</style>
<script>
_onload_ = () => {
- diag = document.getElementById('diag0');
- diag.showModal();
- if (window.testRunner)
- testRunner.dumpAsText();
+ document.querySelector("dialog").showModal();
}
</script>
</head>
<body>
-<dialog id="diag0">
-PASS if this doesn't crash
+<dialog>
+PASS if this displays and doesn't crash
</dialog>
</body>
</html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
