Title: [285854] trunk
- Revision
- 285854
- Author
- cathiec...@igalia.com
- Date
- 2021-11-16 01:46:49 -0800 (Tue, 16 Nov 2021)
Log Message
[CSS contain] The size should be updated if layout containment is inside a fit-content parent
https://bugs.webkit.org/show_bug.cgi?id=233046
Reviewed by Rob Buis.
Source/WebCore:
When the object is a layout containment, we also need to add size containment as the constraint of
being a relayout boundary. Otherwise when the layout size depends on the content, the layout size
might not be updated correctly.
Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html
* rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary):
LayoutTests:
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (285853 => 285854)
--- trunk/LayoutTests/ChangeLog 2021-11-16 07:02:45 UTC (rev 285853)
+++ trunk/LayoutTests/ChangeLog 2021-11-16 09:46:49 UTC (rev 285854)
@@ -1,3 +1,12 @@
+2021-11-16 Cathie Chen <cathiec...@igalia.com>
+
+ [CSS contain] The size should be updated if layout containment is inside a fit-content parent
+ https://bugs.webkit.org/show_bug.cgi?id=233046
+
+ Reviewed by Rob Buis.
+
+ * TestExpectations:
+
2021-11-15 Tim Nguyen <n...@apple.com>
Re-import css/css-text-decor WPT
Modified: trunk/LayoutTests/TestExpectations (285853 => 285854)
--- trunk/LayoutTests/TestExpectations 2021-11-16 07:02:45 UTC (rev 285853)
+++ trunk/LayoutTests/TestExpectations 2021-11-16 09:46:49 UTC (rev 285854)
@@ -4842,7 +4842,6 @@
imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-002.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-003.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-004.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-contain/contain-paint-026.html [ ImageOnlyFailure ]
# Flaky css-contain test
Modified: trunk/Source/WebCore/ChangeLog (285853 => 285854)
--- trunk/Source/WebCore/ChangeLog 2021-11-16 07:02:45 UTC (rev 285853)
+++ trunk/Source/WebCore/ChangeLog 2021-11-16 09:46:49 UTC (rev 285854)
@@ -1,3 +1,19 @@
+2021-11-16 Cathie Chen <cathiec...@igalia.com>
+
+ [CSS contain] The size should be updated if layout containment is inside a fit-content parent
+ https://bugs.webkit.org/show_bug.cgi?id=233046
+
+ Reviewed by Rob Buis.
+
+ When the object is a layout containment, we also need to add size containment as the constraint of
+ being a relayout boundary. Otherwise when the layout size depends on the content, the layout size
+ might not be updated correctly.
+
+ Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html
+
+ * rendering/RenderObject.cpp:
+ (WebCore::objectIsRelayoutBoundary):
+
2021-11-15 Sam Weinig <wei...@apple.com>
Add another <model> backend backed by SceneKit to prove out ModelPlayer infrastructure a bit more
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (285853 => 285854)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2021-11-16 07:02:45 UTC (rev 285853)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2021-11-16 09:46:49 UTC (rev 285854)
@@ -505,7 +505,7 @@
if (object->isTextControl())
return true;
- if (shouldApplyLayoutContainment(*object))
+ if (shouldApplyLayoutContainment(*object) && shouldApplySizeContainment(*object))
return true;
if (object->isSVGRoot())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
