Title: [106928] trunk
- Revision
- 106928
- Author
- yu...@chromium.org
- Date
- 2012-02-07 04:52:48 -0800 (Tue, 07 Feb 2012)
Log Message
Web Inspector: don't mark object is queriable if it is only reachable by internal reference
https://bugs.webkit.org/show_bug.cgi?id=77877
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
LayoutTests:
* inspector/profiler/heap-snapshot.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (106927 => 106928)
--- trunk/LayoutTests/ChangeLog 2012-02-07 12:44:42 UTC (rev 106927)
+++ trunk/LayoutTests/ChangeLog 2012-02-07 12:52:48 UTC (rev 106928)
@@ -1,3 +1,12 @@
+2012-02-06 Yury Semikhatsky <yu...@chromium.org>
+
+ Web Inspector: don't mark object is queriable if it is only reachable by internal reference
+ https://bugs.webkit.org/show_bug.cgi?id=77877
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/profiler/heap-snapshot.html:
+
2012-02-07 Ádám Kallai <kallai.a...@stud.u-szeged.hu>
[Qt] New svg/hittest tests introduced in r106882 fail
Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot.html (106927 => 106928)
--- trunk/LayoutTests/inspector/profiler/heap-snapshot.html 2012-02-07 12:44:42 UTC (rev 106927)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot.html 2012-02-07 12:52:48 UTC (rev 106928)
@@ -162,7 +162,7 @@
"G": false,
"H": false,
"M": false,
- "N": true,
+ "N": false,
"DOMWindow": true
};
for (var nodes = snapshot._allNodes; nodes.hasNext(); nodes.next()) {
Modified: trunk/Source/WebCore/ChangeLog (106927 => 106928)
--- trunk/Source/WebCore/ChangeLog 2012-02-07 12:44:42 UTC (rev 106927)
+++ trunk/Source/WebCore/ChangeLog 2012-02-07 12:52:48 UTC (rev 106928)
@@ -1,3 +1,13 @@
+2012-02-06 Yury Semikhatsky <yu...@chromium.org>
+
+ Web Inspector: don't mark object is queriable if it is only reachable by internal reference
+ https://bugs.webkit.org/show_bug.cgi?id=77877
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/HeapSnapshot.js:
+ (WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
+
2012-02-07 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r106909.
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (106927 => 106928)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2012-02-07 12:44:42 UTC (rev 106927)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js 2012-02-07 12:52:48 UTC (rev 106928)
@@ -1129,14 +1129,14 @@
for (var iter = node.edges; iter.hasNext(); iter.next()) {
var edge = iter.edge;
var node = edge.node;
- if (this._flags[node.nodeIndex])
+ if (this._flags[node.nodeIndex] & flag)
continue;
if (edge.isHidden || edge.isInvisible)
continue;
var name = edge.name;
if (!name)
continue;
- if (edge.isInternal && name !== "native")
+ if (edge.isInternal)
continue;
list.push(node);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
