Title: [286264] trunk
- Revision
- 286264
- Author
- cdu...@apple.com
- Date
- 2021-11-29 14:38:41 -0800 (Mon, 29 Nov 2021)
Log Message
REGRESSION(r283855) [GTK][WPE] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower.html fails
https://bugs.webkit.org/show_bug.cgi?id=233529
Reviewed by Philippe Normand.
Source/WebCore:
The non-USE(ACCELERATE) implementation for VectorMath::multiplyByScalarThenAddToVector() was wrong, causing the test
to fail on non Cocoa ports. The implementation was wrongly calling multiplyByScalarThenAddToOutput() instead of
multiplyByScalar() before calling add().
* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::multiplyByScalarThenAddToVector):
LayoutTests:
Unskip test that is now passing.
* platform/glib/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (286263 => 286264)
--- trunk/LayoutTests/ChangeLog 2021-11-29 22:29:50 UTC (rev 286263)
+++ trunk/LayoutTests/ChangeLog 2021-11-29 22:38:41 UTC (rev 286264)
@@ -1,3 +1,14 @@
+2021-11-29 Chris Dumez <cdu...@apple.com>
+
+ REGRESSION(r283855) [GTK][WPE] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=233529
+
+ Reviewed by Philippe Normand.
+
+ Unskip test that is now passing.
+
+ * platform/glib/TestExpectations:
+
2021-11-29 Chris Fleizach <cfleiz...@apple.com>
AX: Unify speech synthesizer platform usage for Mac/iOS
Modified: trunk/LayoutTests/platform/glib/TestExpectations (286263 => 286264)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-11-29 22:29:50 UTC (rev 286263)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-11-29 22:38:41 UTC (rev 286264)
@@ -1236,8 +1236,6 @@
webkit.org/b/232726 webaudio/AudioBuffer/huge-buffer.html [ Pass Slow ]
-webkit.org/b/233529 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower.html [ Failure ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# End of WebAudio-related bugs
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/Source/WebCore/ChangeLog (286263 => 286264)
--- trunk/Source/WebCore/ChangeLog 2021-11-29 22:29:50 UTC (rev 286263)
+++ trunk/Source/WebCore/ChangeLog 2021-11-29 22:38:41 UTC (rev 286264)
@@ -1,3 +1,17 @@
+2021-11-29 Chris Dumez <cdu...@apple.com>
+
+ REGRESSION(r283855) [GTK][WPE] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=233529
+
+ Reviewed by Philippe Normand.
+
+ The non-USE(ACCELERATE) implementation for VectorMath::multiplyByScalarThenAddToVector() was wrong, causing the test
+ to fail on non Cocoa ports. The implementation was wrongly calling multiplyByScalarThenAddToOutput() instead of
+ multiplyByScalar() before calling add().
+
+ * platform/audio/VectorMath.cpp:
+ (WebCore::VectorMath::multiplyByScalarThenAddToVector):
+
2021-11-29 Fujii Hironori <hironori.fu...@sony.com>
REGRESSION(r286205) [WinCairo] WebGL tests are failing
Modified: trunk/Source/WebCore/platform/audio/VectorMath.cpp (286263 => 286264)
--- trunk/Source/WebCore/platform/audio/VectorMath.cpp 2021-11-29 22:29:50 UTC (rev 286263)
+++ trunk/Source/WebCore/platform/audio/VectorMath.cpp 2021-11-29 22:38:41 UTC (rev 286264)
@@ -145,7 +145,7 @@
void multiplyByScalarThenAddToVector(const float* inputVector1, float scalar, const float* inputVector2, float* outputVector, size_t numberOfElementsToProcess)
{
- multiplyByScalarThenAddToOutput(inputVector1, scalar, outputVector, numberOfElementsToProcess);
+ multiplyByScalar(inputVector1, scalar, outputVector, numberOfElementsToProcess);
add(outputVector, inputVector2, outputVector, numberOfElementsToProcess);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
