[webkit-changes] [286313] trunk/Source/JavaScriptCore

Tue, 30 Nov 2021 12:09:24 -0800

Title: [286313] trunk/Source/_javascript_Core
Revision
286313
Author
commit-qu...@webkit.org
Date
2021-11-30 12:08:27 -0800 (Tue, 30 Nov 2021)

Log Message

Rename "queueTaskToEventLoop" to "queueMicrotaskToEventLoop"
https://bugs.webkit.org/show_bug.cgi?id=233639

Patch by Alexey Shvayka <ashva...@apple.com> on 2021-11-30
Reviewed by Mark Lam.

This change improves grep-ability and avoids confusion since JSDOMWindowBase's
queueMicrotaskToEventLoop() is capable only of scheduling microtasks (hence its signature).
ECMA-262 has no notion of macrotasks, and now JSC hasn't as well.

No behavior change.

* API/JSAPIGlobalObject.cpp:
* API/JSAPIGlobalObject.mm:
* jsc.cpp:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::queueMicrotask):
* runtime/JSGlobalObject.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/JSAPIGlobalObject.cpp (286312 => 286313)


--- trunk/Source/_javascript_Core/API/JSAPIGlobalObject.cpp	2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/_javascript_Core/API/JSAPIGlobalObject.cpp	2021-11-30 20:08:27 UTC (rev 286313)
@@ -38,7 +38,7 @@
     &supportsRichSourceInfo,
     &shouldInterruptScript,
     &_javascript_RuntimeFlags,
-    nullptr, // queueTaskToEventLoop
+    nullptr, // queueMicrotaskToEventLoop
     &shouldInterruptScriptBeforeTimeout,
     nullptr, // moduleLoaderImportModule
     nullptr, // moduleLoaderResolve

Modified: trunk/Source/_javascript_Core/API/JSAPIGlobalObject.mm (286312 => 286313)


--- trunk/Source/_javascript_Core/API/JSAPIGlobalObject.mm	2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/_javascript_Core/API/JSAPIGlobalObject.mm	2021-11-30 20:08:27 UTC (rev 286313)
@@ -56,7 +56,7 @@
     &supportsRichSourceInfo,
     &shouldInterruptScript,
     &_javascript_RuntimeFlags,
-    nullptr, // queueTaskToEventLoop
+    nullptr, // queueMicrotaskToEventLoop
     &shouldInterruptScriptBeforeTimeout,
     &moduleLoaderImportModule, // moduleLoaderImportModule
     &moduleLoaderResolve, // moduleLoaderResolve

Modified: trunk/Source/_javascript_Core/ChangeLog (286312 => 286313)


--- trunk/Source/_javascript_Core/ChangeLog	2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-11-30 20:08:27 UTC (rev 286313)
@@ -1,3 +1,23 @@
+2021-11-30  Alexey Shvayka  <ashva...@apple.com>
+
+        Rename "queueTaskToEventLoop" to "queueMicrotaskToEventLoop"
+        https://bugs.webkit.org/show_bug.cgi?id=233639
+
+        Reviewed by Mark Lam.
+
+        This change improves grep-ability and avoids confusion since JSDOMWindowBase's
+        queueMicrotaskToEventLoop() is capable only of scheduling microtasks (hence its signature).
+        ECMA-262 has no notion of macrotasks, and now JSC hasn't as well.
+
+        No behavior change.
+
+        * API/JSAPIGlobalObject.cpp:
+        * API/JSAPIGlobalObject.mm:
+        * jsc.cpp:
+        * runtime/JSGlobalObject.cpp:
+        (JSC::JSGlobalObject::queueMicrotask):
+        * runtime/JSGlobalObject.h:
+
 2021-11-30  Saam Barati  <sbar...@apple.com>
 
         GetMyArgumentByValOutOfBounds needs to check for negative indices

Modified: trunk/Source/_javascript_Core/jsc.cpp (286312 => 286313)


--- trunk/Source/_javascript_Core/jsc.cpp	2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/_javascript_Core/jsc.cpp	2021-11-30 20:08:27 UTC (rev 286313)
@@ -743,7 +743,7 @@
     &shellSupportsRichSourceInfo,
     &shouldInterruptScript,
     &_javascript_RuntimeFlags,
-    nullptr, // queueTaskToEventLoop
+    nullptr, // queueMicrotaskToEventLoop
     &shouldInterruptScriptBeforeTimeout,
     &moduleLoaderImportModule,
     &moduleLoaderResolve,

Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp (286312 => 286313)


--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2021-11-30 20:08:27 UTC (rev 286313)
@@ -522,7 +522,7 @@
     &supportsRichSourceInfo,
     &shouldInterruptScript,
     &_javascript_RuntimeFlags,
-    nullptr, // queueTaskToEventLoop
+    nullptr, // queueMicrotaskToEventLoop
     &shouldInterruptScriptBeforeTimeout,
     nullptr, // moduleLoaderImportModule
     nullptr, // moduleLoaderResolve
@@ -2554,8 +2554,8 @@
 
 void JSGlobalObject::queueMicrotask(Ref<Microtask>&& task)
 {
-    if (globalObjectMethodTable()->queueTaskToEventLoop) {
-        globalObjectMethodTable()->queueTaskToEventLoop(*this, WTFMove(task));
+    if (globalObjectMethodTable()->queueMicrotaskToEventLoop) {
+        globalObjectMethodTable()->queueMicrotaskToEventLoop(*this, WTFMove(task));
         return;
     }

Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.h (286312 => 286313)


--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.h	2021-11-30 20:00:44 UTC (rev 286312)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.h	2021-11-30 20:08:27 UTC (rev 286313)
@@ -219,8 +219,8 @@
     typedef RuntimeFlags (*_javascript_RuntimeFlagsFunctionPtr)(const JSGlobalObject*);
     _javascript_RuntimeFlagsFunctionPtr _javascript_RuntimeFlags;
 
-    typedef void (*QueueTaskToEventLoopFunctionPtr)(JSGlobalObject&, Ref<Microtask>&&);
-    QueueTaskToEventLoopFunctionPtr queueTaskToEventLoop;
+    typedef void (*QueueMicrotaskToEventLoopFunctionPtr)(JSGlobalObject&, Ref<Microtask>&&);
+    QueueMicrotaskToEventLoopFunctionPtr queueMicrotaskToEventLoop;
 
     typedef bool (*ShouldInterruptScriptBeforeTimeoutPtr)(const JSGlobalObject*);
     ShouldInterruptScriptBeforeTimeoutPtr shouldInterruptScriptBeforeTimeout;

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to