Title: [286450] trunk
Revision
286450
Author
wenson_hs...@apple.com
Date
2021-12-02 13:33:49 -0800 (Thu, 02 Dec 2021)

Log Message

[ Monterey ] fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html (layout-test) is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=233658
rdar://problem/85886424

Reviewed by Tim Horton.

Source/WTF:

Define ENABLE_APP_HIGHLIGHTS for iOS 15+ and macOS Monterey+. This ensures that
`internals.appHighlightContextMenuItemTitles` is defined in layout tests on Monterey.

* wtf/PlatformEnableCocoa.h:

Tools:

Add a forward declaration for open source builds.

* TestWebKitAPI/ios/UIKitSPI.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (286449 => 286450)


--- trunk/Source/WTF/ChangeLog	2021-12-02 21:26:40 UTC (rev 286449)
+++ trunk/Source/WTF/ChangeLog	2021-12-02 21:33:49 UTC (rev 286450)
@@ -1,3 +1,16 @@
+2021-12-02  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        [ Monterey ] fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html (layout-test) is a constant text failure
+        https://bugs.webkit.org/show_bug.cgi?id=233658
+        rdar://problem/85886424
+
+        Reviewed by Tim Horton.
+
+        Define ENABLE_APP_HIGHLIGHTS for iOS 15+ and macOS Monterey+. This ensures that
+        `internals.appHighlightContextMenuItemTitles` is defined in layout tests on Monterey.
+
+        * wtf/PlatformEnableCocoa.h:
+
 2021-12-02  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, reverting r286437.

Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (286449 => 286450)


--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2021-12-02 21:26:40 UTC (rev 286449)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2021-12-02 21:33:49 UTC (rev 286450)
@@ -716,6 +716,12 @@
 #define ENABLE_APP_PRIVACY_REPORT 1
 #endif
 
+#if (!defined(ENABLE_APP_HIGHLIGHTS) && \
+    (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 \
+    || PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000))
+#define ENABLE_APP_HIGHLIGHTS 1
+#endif
+
 #if !defined(ENABLE_DESTINATION_COLOR_SPACE_DISPLAY_P3)
 #define ENABLE_DESTINATION_COLOR_SPACE_DISPLAY_P3 1
 #endif

Modified: trunk/Tools/ChangeLog (286449 => 286450)


--- trunk/Tools/ChangeLog	2021-12-02 21:26:40 UTC (rev 286449)
+++ trunk/Tools/ChangeLog	2021-12-02 21:33:49 UTC (rev 286450)
@@ -1,3 +1,15 @@
+2021-12-02  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        [ Monterey ] fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html (layout-test) is a constant text failure
+        https://bugs.webkit.org/show_bug.cgi?id=233658
+        rdar://problem/85886424
+
+        Reviewed by Tim Horton.
+
+        Add a forward declaration for open source builds.
+
+        * TestWebKitAPI/ios/UIKitSPI.h:
+
 2021-12-02  Brady Eidson  <beid...@apple.com>
 
         REGRESSION: r286075 [ Big Sur x86] 2 TestWebKitAPI.WebPushD (API-Tests) are constant failures

Modified: trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h (286449 => 286450)


--- trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h	2021-12-02 21:26:40 UTC (rev 286449)
+++ trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h	2021-12-02 21:33:49 UTC (rev 286450)
@@ -140,6 +140,7 @@
 
 @interface UICalloutBar : UIView
 + (UICalloutBar *)sharedCalloutBar;
++ (UICalloutBar *)activeCalloutBar;
 @end
 
 @interface _UINavigationInteractiveTransitionBase : UIPercentDrivenInteractiveTransition
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to