Title: [286834] trunk/Source/WebKit
- Revision
- 286834
- Author
- simon.fra...@apple.com
- Date
- 2021-12-09 22:55:24 -0800 (Thu, 09 Dec 2021)
Log Message
Inspector "composite" events are all very short
https://bugs.webkit.org/show_bug.cgi?id=234114
<rdar://86299391>
Reviewed by Tim Horton.
The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
time to include painting so use kCATransactionPhasePreLayout.
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (286833 => 286834)
--- trunk/Source/WebKit/ChangeLog 2021-12-10 06:24:31 UTC (rev 286833)
+++ trunk/Source/WebKit/ChangeLog 2021-12-10 06:55:24 UTC (rev 286834)
@@ -1,3 +1,19 @@
+2021-12-09 Simon Fraser <simon.fra...@apple.com>
+
+ Inspector "composite" events are all very short
+ https://bugs.webkit.org/show_bug.cgi?id=234114
+ <rdar://86299391>
+
+ Reviewed by Tim Horton.
+
+ The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
+ time to include painting so use kCATransactionPhasePreLayout.
+
+ * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
+ (WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
+ * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+ (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
+
2021-12-09 Aditya Keerthi <akeer...@apple.com>
Fix the tvOS and watchOS builds after r286641
Modified: trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm (286833 => 286834)
--- trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm 2021-12-10 06:24:31 UTC (rev 286833)
+++ trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm 2021-12-10 06:55:24 UTC (rev 286834)
@@ -293,7 +293,7 @@
if (Frame* coreFrame = retainedPage->mainFrame())
corePage->inspectorController().willComposite(*coreFrame);
}
- } forPhase:kCATransactionPhasePreCommit];
+ } forPhase:kCATransactionPhasePreLayout];
[CATransaction addCommitHandler:[retainedPage = Ref { m_webPage }] {
if (Page* corePage = retainedPage->corePage()) {
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (286833 => 286834)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2021-12-10 06:24:31 UTC (rev 286833)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2021-12-10 06:55:24 UTC (rev 286834)
@@ -418,7 +418,7 @@
if (Frame* coreFrame = retainedPage->mainFrame())
corePage->inspectorController().willComposite(*coreFrame);
}
- } forPhase:kCATransactionPhasePreCommit];
+ } forPhase:kCATransactionPhasePreLayout];
[CATransaction addCommitHandler:[retainedPage = Ref { m_webPage }] {
if (Page* corePage = retainedPage->corePage()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
