Title: [286841] trunk/Source/WebKit
- Revision
- 286841
- Author
- you...@apple.com
- Date
- 2021-12-10 02:39:28 -0800 (Fri, 10 Dec 2021)
Log Message
REGRESSION (iOS 15): Safari loses Network access when establishing WebRTC session
https://bugs.webkit.org/show_bug.cgi?id=233752
<rdar://problem/86196093>
Reviewed by Geoffrey Garen.
When we get an error from a UDP nw socket, we do not need to stop reading and close it.
We can just log the error and continue reading as the error might get fixed later on.
Not easily testable.
* NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (286840 => 286841)
--- trunk/Source/WebKit/ChangeLog 2021-12-10 10:30:48 UTC (rev 286840)
+++ trunk/Source/WebKit/ChangeLog 2021-12-10 10:39:28 UTC (rev 286841)
@@ -1,3 +1,18 @@
+2021-12-10 Youenn Fablet <you...@apple.com>
+
+ REGRESSION (iOS 15): Safari loses Network access when establishing WebRTC session
+ https://bugs.webkit.org/show_bug.cgi?id=233752
+ <rdar://problem/86196093>
+
+ Reviewed by Geoffrey Garen.
+
+ When we get an error from a UDP nw socket, we do not need to stop reading and close it.
+ We can just log the error and continue reading as the error might get fixed later on.
+
+ Not easily testable.
+
+ * NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
+
2021-12-10 Kimmo Kinnunen <kkinnu...@apple.com>
IOSurface memory attribution is hard to use in constructors
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm (286840 => 286841)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm 2021-12-10 10:30:48 UTC (rev 286840)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm 2021-12-10 10:39:28 UTC (rev 286841)
@@ -288,10 +288,8 @@
}
if (isComplete && context && nw_content_context_get_is_final(context))
return;
- if (error) {
- RELEASE_LOG_ERROR(WebRTC, "NetworkRTCUDPSocketCocoaConnections failed processing UDP data with error %d", nw_error_get_error_code(error));
- return;
- }
+
+ RELEASE_LOG_ERROR_IF(!!error, WebRTC, "NetworkRTCUDPSocketCocoaConnections failed processing UDP data with error %d", nw_error_get_error_code(error));
processUDPData(WTFMove(nwConnection), WTFMove(processData));
}).get());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
