Title: [106998] trunk/Source/WebCore
- Revision
- 106998
- Author
- hara...@chromium.org
- Date
- 2012-02-07 15:38:19 -0800 (Tue, 07 Feb 2012)
Log Message
[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=77957
Reviewed by Adam Barth.
This patch replaces IsSubType("WorkerContext") and something equivalent that
with the [IsWorkerContext] IDL.
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
(GenerateConstructorGetter):
(GenerateImplementation):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (106997 => 106998)
--- trunk/Source/WebCore/ChangeLog 2012-02-07 23:29:58 UTC (rev 106997)
+++ trunk/Source/WebCore/ChangeLog 2012-02-07 23:38:19 UTC (rev 106998)
@@ -1,3 +1,20 @@
+2012-02-07 Kentaro Hara <hara...@chromium.org>
+
+ [Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
+ https://bugs.webkit.org/show_bug.cgi?id=77957
+
+ Reviewed by Adam Barth.
+
+ This patch replaces IsSubType("WorkerContext") and something equivalent that
+ with the [IsWorkerContext] IDL.
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GetInternalFields):
+ (GenerateConstructorGetter):
+ (GenerateImplementation):
+
2012-02-07 David Reveman <reve...@chromium.org>
[Chromium] Crash when using per-tile painting on Windows.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (106997 => 106998)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-02-07 23:29:58 UTC (rev 106997)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-02-07 23:38:19 UTC (rev 106998)
@@ -505,17 +505,17 @@
{
my $dataNode = shift;
my $name = $dataNode->name;
-
+
my @customInternalFields = ();
-
- # We can't ask whether a parent type has a given extendedAttribute, so special-case AbstractWorker and WorkerContext to include all sub-types.
+ # We can't ask whether a parent type has a given extendedAttribute,
+ # so special-case AbstractWorker and WorkerContext to include all sub-types.
# Event listeners on DOM nodes are explicitly supported in the GC controller.
# FIXME: SVGElementInstance should probably have the EventTarget extended attribute, but doesn't.
- if (!IsNodeSubType($dataNode) &&
- ($dataNode->extendedAttributes->{"EventTarget"} ||
- IsSubType($dataNode, "AbstractWorker") ||
- IsSubType($dataNode, "WorkerContext") ||
- $name eq "SVGElementInstance")) {
+ if (!IsNodeSubType($dataNode)
+ && ($dataNode->extendedAttributes->{"EventTarget"}
+ || $dataNode->extendedAttributes->{"IsWorkerContext"}
+ || IsSubType($dataNode, "AbstractWorker")
+ || $name eq "SVGElementInstance")) {
push(@customInternalFields, "eventListenerCacheIndex");
}
@@ -735,6 +735,7 @@
sub GenerateConstructorGetter
{
+ my $dataNode = shift;
my $implClassName = shift;
push(@implContentDecls, <<END);
@@ -753,7 +754,7 @@
// context of the DOMWindow and not in the context of the caller.
return V8DOMWrapper::getConstructor(type, V8DOMWindow::toNative(info.Holder()));
END
- } elsif ($implClassName eq "DedicatedWorkerContext" or $implClassName eq "WorkerContext" or $implClassName eq "SharedWorkerContext") {
+ } elsif ($dataNode->extendedAttributes->{"IsWorkerContext"}) {
push(@implContentDecls, <<END);
return V8DOMWrapper::getConstructor(type, V8WorkerContext::toNative(info.Holder()));
END
@@ -2310,7 +2311,7 @@
}
if ($hasConstructors) {
- GenerateConstructorGetter($implClassName);
+ GenerateConstructorGetter($dataNode, $implClassName);
}
my $indexer;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
