Title: [107004] trunk/Source/WebCore
Revision
107004
Author
hara...@chromium.org
Date
2012-02-07 16:00:18 -0800 (Tue, 07 Feb 2012)

Log Message

Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=77973

Reviewed by Adam Barth.

This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
attributes should be prefixed by "V8".

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (107003 => 107004)


--- trunk/Source/WebCore/ChangeLog	2012-02-07 23:58:33 UTC (rev 107003)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 00:00:18 UTC (rev 107004)
@@ -1,3 +1,21 @@
+2012-02-07  Kentaro Hara  <hara...@chromium.org>
+
+        Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
+        https://bugs.webkit.org/show_bug.cgi?id=77973
+
+        Reviewed by Adam Barth.
+
+        This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
+        attributes should be prefixed by "V8".
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateNormalAttrGetter):
+        (GenerateNormalAttrSetter):
+        (GenerateSingleBatchedAttribute):
+        (GenerateImplementation):
+
 2011-10-10  Jer Noble  <jer.no...@apple.com>
 
         media/audio-data-url.html test broken on Lion

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (107003 => 107004)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-02-07 23:58:33 UTC (rev 107003)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-02-08 00:00:18 UTC (rev 107004)
@@ -810,7 +810,7 @@
 END
             }
         }
-    } elsif ($attrExt->{"v8OnProto"} || $attrExt->{"V8Unforgeable"}) {
+    } elsif ($attrExt->{"V8OnProto"} || $attrExt->{"V8Unforgeable"}) {
         if ($interfaceName eq "DOMWindow") {
             push(@implContentDecls, <<END);
     v8::Handle<v8::Object> holder = info.Holder();
@@ -1054,7 +1054,7 @@
             push(@implContentDecls, "    $svgWrappedNativeType& impInstance = wrapper->propertyReference();\n");
             push(@implContentDecls, "    $svgWrappedNativeType* imp = &impInstance;\n");
         }
-    } elsif ($attrExt->{"v8OnProto"}) {
+    } elsif ($attrExt->{"V8OnProto"}) {
       if ($interfaceName eq "DOMWindow") {
         push(@implContentDecls, <<END);
     v8::Handle<v8::Object> holder = info.Holder();
@@ -2030,7 +2030,7 @@
     }
 
     # An accessor can be installed on the proto
-    if ($attrExt->{"v8OnProto"}) {
+    if ($attrExt->{"V8OnProto"}) {
         $_on_proto_ = "1 /* on proto */";
     }
 
@@ -2281,7 +2281,7 @@
         }
 
         if ($attrType eq "EventListener" && $interfaceName eq "DOMWindow") {
-            $attribute->signature->extendedAttributes->{"v8OnProto"} = 1;
+            $attribute->signature->extendedAttributes->{"V8OnProto"} = 1;
         }
 
         if ($attrType eq "SerializedScriptValue") {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to