Title: [286933] trunk/Source/WebCore
- Revision
- 286933
- Author
- za...@apple.com
- Date
- 2021-12-12 19:23:12 -0800 (Sun, 12 Dec 2021)
Log Message
[IFC][Integration] Enable isolate-override for inline boxes
https://bugs.webkit.org/show_bug.cgi?id=234203
Reviewed by Antti Koivisto.
* layout/integration/LayoutIntegrationCoverage.cpp: The only reason why plaintext is not enabled yet
is becuase it may change the inline axis direction to RTL. It is going to be enabled together with the RTL support.
(WebCore::LayoutIntegration::canUseForStyle):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (286932 => 286933)
--- trunk/Source/WebCore/ChangeLog 2021-12-13 02:42:35 UTC (rev 286932)
+++ trunk/Source/WebCore/ChangeLog 2021-12-13 03:23:12 UTC (rev 286933)
@@ -1,3 +1,14 @@
+2021-12-12 Alan Bujtas <za...@apple.com>
+
+ [IFC][Integration] Enable isolate-override for inline boxes
+ https://bugs.webkit.org/show_bug.cgi?id=234203
+
+ Reviewed by Antti Koivisto.
+
+ * layout/integration/LayoutIntegrationCoverage.cpp: The only reason why plaintext is not enabled yet
+ is becuase it may change the inline axis direction to RTL. It is going to be enabled together with the RTL support.
+ (WebCore::LayoutIntegration::canUseForStyle):
+
2021-12-12 Simon Fraser <simon.fra...@apple.com>
Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (286932 => 286933)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2021-12-13 02:42:35 UTC (rev 286932)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp 2021-12-13 03:23:12 UTC (rev 286933)
@@ -116,8 +116,8 @@
case AvoidanceReason::FlowHasOverflowNotVisible:
stream << "overflow: hidden | scroll | auto";
break;
- case AvoidanceReason::FlowIsNotLTR:
- stream << "dir is not LTR";
+ case AvoidanceReason::FlowMayNotBeLTR:
+ stream << "dir may not be LTR";
break;
case AvoidanceReason::FlowHasLineBoxContainProperty:
stream << "line-box-contain value indicates variable line height";
@@ -125,9 +125,6 @@
case AvoidanceReason::FlowIsNotTopToBottom:
stream << "non top-to-bottom flow";
break;
- case AvoidanceReason::FlowHasNonNormalUnicodeBiDi:
- stream << "non-normal Unicode bidi";
- break;
case AvoidanceReason::FlowHasRTLOrdering:
stream << "-webkit-rtl-ordering";
break;
@@ -437,17 +434,10 @@
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasOverflowNotVisible, reasons, includeReasons);
if (style.textOverflow() == TextOverflow::Ellipsis)
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasTextOverflow, reasons, includeReasons);
- if (!style.isLeftToRightDirection())
- SET_REASON_AND_RETURN_IF_NEEDED(FlowIsNotLTR, reasons, includeReasons);
+ if (!style.isLeftToRightDirection() || (is<RenderBlockFlow>(renderer) && style.unicodeBidi() == EUnicodeBidi::Plaintext))
+ SET_REASON_AND_RETURN_IF_NEEDED(FlowMayNotBeLTR, reasons, includeReasons);
if (style.writingMode() != WritingMode::TopToBottom)
SET_REASON_AND_RETURN_IF_NEEDED(FlowIsNotTopToBottom, reasons, includeReasons);
- if (style.unicodeBidi() != UBNormal) {
- auto unicodeBidi = style.unicodeBidi();
- if (unicodeBidi == EUnicodeBidi::Plaintext)
- SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonNormalUnicodeBiDi, reasons, includeReasons);
- if (!is<RenderBlockFlow>(renderer) && unicodeBidi == EUnicodeBidi::IsolateOverride)
- SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonNormalUnicodeBiDi, reasons, includeReasons);
- }
if (style.rtlOrdering() != Order::Logical)
SET_REASON_AND_RETURN_IF_NEEDED(FlowHasRTLOrdering, reasons, includeReasons);
if (style.textEmphasisFill() != TextEmphasisFill::Filled || style.textEmphasisMark() != TextEmphasisMark::None)
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h (286932 => 286933)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h 2021-12-13 02:42:35 UTC (rev 286932)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.h 2021-12-13 03:23:12 UTC (rev 286933)
@@ -53,10 +53,10 @@
// Unused = 1LLU << 12,
FlowHasOverflowNotVisible = 1LLU << 13,
// Unused = 1LLU << 14,
- FlowIsNotLTR = 1LLU << 15,
+ FlowMayNotBeLTR = 1LLU << 15,
FlowHasLineBoxContainProperty = 1LLU << 16,
FlowIsNotTopToBottom = 1LLU << 17,
- FlowHasNonNormalUnicodeBiDi = 1LLU << 18,
+ // Unused = 1LLU << 18,
FlowHasRTLOrdering = 1LLU << 19,
FlowHasLineAlignEdges = 1LLU << 20,
FlowHasLineSnap = 1LLU << 21,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
