Title: [107034] trunk/Source/WebCore
- Revision
- 107034
- Author
- hara...@chromium.org
- Date
- 2012-02-07 20:14:02 -0800 (Tue, 07 Feb 2012)
Log Message
[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=78059
Reviewed by Adam Barth.
CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].
Test: bindings/scripts/test/TestObj.idl
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (107033 => 107034)
--- trunk/Source/WebCore/ChangeLog 2012-02-08 04:05:20 UTC (rev 107033)
+++ trunk/Source/WebCore/ChangeLog 2012-02-08 04:14:02 UTC (rev 107034)
@@ -1,3 +1,21 @@
+2012-02-07 Kentaro Hara <hara...@chromium.org>
+
+ [GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
+ https://bugs.webkit.org/show_bug.cgi?id=78059
+
+ Reviewed by Adam Barth.
+
+ CodeGeneratorGObject.pm does not support custom attributes.
+ We can skip generating code for attributes with [Custom].
+ The change would make sense, since CodeGeneratorGObject.pm already
+ skips attributes with [CustomGetter] or [CustomSetter].
+
+ Test: bindings/scripts/test/TestObj.idl
+
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (SkipAttribute):
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+
2012-02-07 Emil A Eklund <e...@chromium.org>
Add pixelSnappedX/Y/Width/Height methods
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (107033 => 107034)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2012-02-08 04:05:20 UTC (rev 107033)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2012-02-08 04:14:02 UTC (rev 107034)
@@ -152,9 +152,10 @@
sub SkipAttribute {
my $attribute = shift;
-
- if ($attribute->signature->extendedAttributes->{"CustomGetter"} ||
- $attribute->signature->extendedAttributes->{"CustomSetter"}) {
+
+ if ($attribute->signature->extendedAttributes->{"Custom"}
+ || $attribute->signature->extendedAttributes->{"CustomGetter"}
+ || $attribute->signature->extendedAttributes->{"CustomSetter"}) {
return 1;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp (107033 => 107034)
--- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2012-02-08 04:05:20 UTC (rev 107033)
+++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2012-02-08 04:14:02 UTC (rev 107034)
@@ -1406,7 +1406,6 @@
PROP_ATTR_WITH_SETTER_EXCEPTION,
PROP_STRING_ATTR_WITH_GETTER_EXCEPTION,
PROP_STRING_ATTR_WITH_SETTER_EXCEPTION,
- PROP_CUSTOM_ATTR,
PROP_WITH_SCRIPT_STATE_ATTRIBUTE,
PROP_WITH_SCRIPT_EXECUTION_CONTEXT_ATTRIBUTE,
PROP_WITH_SCRIPT_STATE_ATTRIBUTE_RAISES,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
