Title: [287254] trunk/Tools
- Revision
- 287254
- Author
- lmo...@igalia.com
- Date
- 2021-12-20 01:20:53 -0800 (Mon, 20 Dec 2021)
Log Message
REGRESSION(r286936) [GLIB] WebsiteData configuration API test is failing with non-created localstorage dir
https://bugs.webkit.org/show_bug.cgi?id=234497
Reviewed by Adrian Perez de Castro.
* TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataConfiguration): Ensure localStorage is created before
trying to query it.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (287253 => 287254)
--- trunk/Tools/ChangeLog 2021-12-20 05:03:26 UTC (rev 287253)
+++ trunk/Tools/ChangeLog 2021-12-20 09:20:53 UTC (rev 287254)
@@ -1,3 +1,14 @@
+2021-12-20 Lauro Moura <lmo...@igalia.com>
+
+ REGRESSION(r286936) [GLIB] WebsiteData configuration API test is failing with non-created localstorage dir
+ https://bugs.webkit.org/show_bug.cgi?id=234497
+
+ Reviewed by Adrian Perez de Castro.
+
+ * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
+ (testWebsiteDataConfiguration): Ensure localStorage is created before
+ trying to query it.
+
2021-12-18 Alex Christensen <achristen...@webkit.org>
[Monterey] TestWebKitAPI.PrivateClickMeasurement.Daemon* tests timing out: Failed to connect to mach service org.webkit.pcmtestdaemon.service
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp (287253 => 287254)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp 2021-12-20 05:03:26 UTC (rev 287253)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp 2021-12-20 09:20:53 UTC (rev 287254)
@@ -166,8 +166,12 @@
g_assert_null(webkit_website_data_manager_get_base_data_directory(test->m_manager));
g_assert_null(webkit_website_data_manager_get_base_cache_directory(test->m_manager));
+ test->loadURI(kServer->getURIForPath("/empty").data());
+ test->waitUntilLoadFinished();
+ test->runJavaScriptAndWaitUntilFinished("window.localStorage.clear();", nullptr);
GUniquePtr<char> localStorageDirectory(g_build_filename(Test::dataDirectory(), "local-storage", nullptr));
g_assert_cmpstr(localStorageDirectory.get(), ==, webkit_website_data_manager_get_local_storage_directory(test->m_manager));
+ test->assertFileIsCreated(localStorageDirectory.get());
g_assert_true(g_file_test(localStorageDirectory.get(), G_FILE_TEST_IS_DIR));
test->loadURI(kServer->getURIForPath("/empty").data());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
