Title: [287298] trunk/Tools
- Revision
- 287298
- Author
- commit-qu...@webkit.org
- Date
- 2021-12-20 22:22:38 -0800 (Mon, 20 Dec 2021)
Log Message
REGRESSION: [ iOS ] 5 TestWebKitAPI.WebpagePreferences.* api tests are flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=229094
Patch by Alex Christensen <achristen...@webkit.org> on 2021-12-20
Reviewed by Darin Adler.
The tests don't seem to time out any more. Let's try re-enabling them.
* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (287297 => 287298)
--- trunk/Tools/ChangeLog 2021-12-21 04:52:11 UTC (rev 287297)
+++ trunk/Tools/ChangeLog 2021-12-21 06:22:38 UTC (rev 287298)
@@ -1,3 +1,15 @@
+2021-12-20 Alex Christensen <achristen...@webkit.org>
+
+ REGRESSION: [ iOS ] 5 TestWebKitAPI.WebpagePreferences.* api tests are flaky timing out
+ https://bugs.webkit.org/show_bug.cgi?id=229094
+
+ Reviewed by Darin Adler.
+
+ The tests don't seem to time out any more. Let's try re-enabling them.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
+ (TEST):
+
2021-12-20 Fujii Hironori <hironori.fu...@sony.com>
[Win] MSVC reports "DumpRenderTree.cpp(633): error C2362: initialization of 'length' is skipped by 'goto exit'" with /std:c++20
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm (287297 => 287298)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm 2021-12-21 04:52:11 UTC (rev 287297)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm 2021-12-21 06:22:38 UTC (rev 287298)
@@ -256,12 +256,7 @@
@end
-// FIXME: This test is timing out on iOS simulator. See https://bugs.webkit.org/show_bug.cgi?id=229094
-#if PLATFORM(MAC)
TEST(WebpagePreferences, WebsitePoliciesAutoplayEnabled)
-#else
-TEST(WebpagePreferences, DISABLED_WebsitePoliciesAutoplayEnabled)
-#endif
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
@@ -435,12 +430,7 @@
}
#endif
-// FIXME: This test is timing out on iOS simulator. See https://bugs.webkit.org/show_bug.cgi?id=229094
-#if PLATFORM(MAC)
TEST(WebpagePreferences, WebsitePoliciesPlayingWithUserGesture)
-#else
-TEST(WebpagePreferences, DISABLED_WebsitePoliciesPlayingWithUserGesture)
-#endif
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
#if PLATFORM(IOS_FAMILY)
@@ -496,12 +486,7 @@
ASSERT_TRUE(*receivedAutoplayEventFlags & _WKAutoplayEventFlagsMediaIsMainContent);
}
-// FIXME: This test is timing out on iOS simulator. See https://bugs.webkit.org/show_bug.cgi?id=229094
-#if PLATFORM(MAC)
TEST(WebpagePreferences, WebsitePoliciesPlayingWithoutInterference)
-#else
-TEST(WebpagePreferences, DISABLED_WebsitePoliciesPlayingWithoutInterference)
-#endif
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
#if PLATFORM(IOS_FAMILY)
@@ -525,12 +510,7 @@
ASSERT_TRUE(*receivedAutoplayEventFlags & _WKAutoplayEventFlagsHasAudio);
}
-// FIXME: This test is timing out on iOS simulator. See https://bugs.webkit.org/show_bug.cgi?id=229094
-#if PLATFORM(MAC)
TEST(WebpagePreferences, WebsitePoliciesUserInterferenceWithPlaying)
-#else
-TEST(WebpagePreferences, DISABLED_WebsitePoliciesUserInterferenceWithPlaying)
-#endif
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
#if PLATFORM(IOS_FAMILY)
@@ -755,12 +735,7 @@
}
#endif // PLATFORM(MAC)
-// FIXME: This test is timing out on iOS simulator. See https://bugs.webkit.org/show_bug.cgi?id=229094
-#if PLATFORM(MAC)
TEST(WebpagePreferences, WebsitePoliciesUpdates)
-#else
-TEST(WebpagePreferences, DISABLED_WebsitePoliciesUpdates)
-#endif
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
#if PLATFORM(IOS_FAMILY)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
