Title: [287300] trunk/Source/WebCore
- Revision
- 287300
- Author
- hironori.fu...@sony.com
- Date
- 2021-12-21 00:28:56 -0800 (Tue, 21 Dec 2021)
Log Message
MSVC reports "SVGPropertyAnimator.h(94): error C2839: invalid return type 'T *' for overloaded 'operator ->'" with /std:c++20
https://bugs.webkit.org/show_bug.cgi?id=234546
Reviewed by Alex Christensen.
* svg/properties/SVGPropertyAnimator.h:
(WebCore::SVGPropertyAnimator::computeInheritedCSSPropertyValue const):
computeCSSPropertyValue protects the first arguemnt SVGElement.
computeInheritedCSSPropertyValue doesn't need to protect "parent".
Use Element* instead of RefPtr for "parent".
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (287299 => 287300)
--- trunk/Source/WebCore/ChangeLog 2021-12-21 07:19:39 UTC (rev 287299)
+++ trunk/Source/WebCore/ChangeLog 2021-12-21 08:28:56 UTC (rev 287300)
@@ -1,3 +1,16 @@
+2021-12-21 Fujii Hironori <hironori.fu...@sony.com>
+
+ MSVC reports "SVGPropertyAnimator.h(94): error C2839: invalid return type 'T *' for overloaded 'operator ->'" with /std:c++20
+ https://bugs.webkit.org/show_bug.cgi?id=234546
+
+ Reviewed by Alex Christensen.
+
+ * svg/properties/SVGPropertyAnimator.h:
+ (WebCore::SVGPropertyAnimator::computeInheritedCSSPropertyValue const):
+ computeCSSPropertyValue protects the first arguemnt SVGElement.
+ computeInheritedCSSPropertyValue doesn't need to protect "parent".
+ Use Element* instead of RefPtr for "parent".
+
2021-12-20 Fujii Hironori <hironori.fu...@sony.com>
[Win] MSVC reports "DownloadBundleWin.cpp(87): error C2362: initialization of 'magic' is skipped by 'goto exit'" with /std:c++20
Modified: trunk/Source/WebCore/svg/properties/SVGPropertyAnimator.h (287299 => 287300)
--- trunk/Source/WebCore/svg/properties/SVGPropertyAnimator.h 2021-12-21 07:19:39 UTC (rev 287299)
+++ trunk/Source/WebCore/svg/properties/SVGPropertyAnimator.h 2021-12-21 08:28:56 UTC (rev 287300)
@@ -89,7 +89,7 @@
String computeInheritedCSSPropertyValue(SVGElement& targetElement) const
{
- RefPtr parent = targetElement.parentElement();
+ auto* parent = targetElement.parentElement();
if (!parent || !parent->isSVGElement())
return emptyString();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
