Diff
Modified: trunk/Source/WebCore/ChangeLog (107050 => 107051)
--- trunk/Source/WebCore/ChangeLog 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/ChangeLog 2012-02-08 08:57:50 UTC (rev 107051)
@@ -1,5 +1,34 @@
2012-02-08 Kentaro Hara <hara...@chromium.org>
+ Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
+ https://bugs.webkit.org/show_bug.cgi?id=77963
+
+ Reviewed by Adam Barth.
+
+ This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
+ for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateHeader):
+ (GenerateImplementation):
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeaderNamedAndIndexedPropertyAccessors):
+ (GenerateImplementationIndexer):
+ (GenerateImplementationNamedPropertyGetter):
+ * bindings/scripts/test/TestInterface.idl:
+ * css/CSSStyleDeclaration.idl:
+ * dom/DOMStringMap.idl:
+ * html/HTMLAppletElement.idl:
+ * html/HTMLEmbedElement.idl:
+ * html/HTMLObjectElement.idl:
+ * page/History.idl:
+ * page/Location.idl:
+ * storage/Storage.idl:
+
+2012-02-08 Kentaro Hara <hara...@chromium.org>
+
Replace [CheckNodeSecurity] with [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77971
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (107050 => 107051)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-02-08 08:57:50 UTC (rev 107051)
@@ -751,7 +751,7 @@
$headerTrailingIncludes{"${className}Custom.h"} = 1 if $dataNode->extendedAttributes->{"CustomHeader"};
- $implIncludes{"${className}Custom.h"} = 1 if !$dataNode->extendedAttributes->{"CustomHeader"} && ($dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"DelegatingPutFunction"});
+ $implIncludes{"${className}Custom.h"} = 1 if !$dataNode->extendedAttributes->{"CustomHeader"} && ($dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"CustomNamedSetter"});
my $hasGetter = $numAttributes > 0
|| !$dataNode->extendedAttributes->{"OmitConstructor"}
@@ -782,14 +782,14 @@
my $hasSetter = $hasReadWriteProperties
|| $dataNode->extendedAttributes->{"CustomPutFunction"}
- || $dataNode->extendedAttributes->{"DelegatingPutFunction"}
+ || $dataNode->extendedAttributes->{"CustomNamedSetter"}
|| $dataNode->extendedAttributes->{"CustomIndexedSetter"};
# Getters
if ($hasSetter) {
push(@headerContent, " static void put(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);\n");
push(@headerContent, " static void putByIndex(JSC::JSCell*, JSC::ExecState*, unsigned propertyName, JSC::JSValue);\n") if $dataNode->extendedAttributes->{"CustomIndexedSetter"};
- push(@headerContent, " bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n") if $dataNode->extendedAttributes->{"DelegatingPutFunction"};
+ push(@headerContent, " bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n") if $dataNode->extendedAttributes->{"CustomNamedSetter"};
}
if (!$hasParent) {
@@ -1825,7 +1825,7 @@
}
my $hasSetter = $hasReadWriteProperties
- || $dataNode->extendedAttributes->{"DelegatingPutFunction"}
+ || $dataNode->extendedAttributes->{"CustomNamedSetter"}
|| $dataNode->extendedAttributes->{"CustomIndexedSetter"};
if ($hasSetter) {
@@ -1842,7 +1842,7 @@
push(@implContent, " return;\n");
push(@implContent, " }\n");
}
- if ($dataNode->extendedAttributes->{"DelegatingPutFunction"}) {
+ if ($dataNode->extendedAttributes->{"CustomNamedSetter"}) {
push(@implContent, " if (thisObject->putDelegate(exec, propertyName, value, slot))\n");
push(@implContent, " return;\n");
}
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (107050 => 107051)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-02-08 08:57:50 UTC (rev 107051)
@@ -566,7 +566,7 @@
my $hasCustomIndexedGetter = $dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
my $hasCustomIndexedSetter = $dataNode->extendedAttributes->{"CustomIndexedSetter"} && !$dataNode->extendedAttributes->{"HasNumericIndexGetter"};
my $hasCustomNamedGetter = $dataNode->extendedAttributes->{"NamedGetter"} || $dataNode->extendedAttributes->{"CustomNamedGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
- my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"DelegatingPutFunction"};
+ my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"CustomNamedSetter"};
my $hasCustomDeleters = $dataNode->extendedAttributes->{"CustomDeleteProperty"};
my $hasCustomEnumerator = $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
if ($interfaceName eq "HTMLOptionsCollection") {
@@ -2062,7 +2062,7 @@
my $isSpecialCase = exists $indexerSpecialCases{$interfaceName};
if ($isSpecialCase) {
$hasGetter = 1;
- if ($dataNode->extendedAttributes->{"DelegatingPutFunction"}) {
+ if ($dataNode->extendedAttributes->{"CustomNamedSetter"}) {
$hasCustomSetter = 1;
}
}
@@ -2168,7 +2168,7 @@
return;
}
- my $hasSetter = $dataNode->extendedAttributes->{"DelegatingPutFunction"};
+ my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"CustomNamedSetter"};
my $hasDeleter = $dataNode->extendedAttributes->{"CustomDeleteProperty"};
my $hasEnumerator = $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
my $setOn = "Instance";
@@ -2184,7 +2184,7 @@
}
push(@implContent, " desc->${setOn}Template()->SetNamedPropertyHandler(V8${interfaceName}::namedPropertyGetter, ");
- push(@implContent, $hasSetter ? "V8${interfaceName}::namedPropertySetter, " : "0, ");
+ push(@implContent, $hasCustomNamedSetter ? "V8${interfaceName}::namedPropertySetter, " : "0, ");
# If there is a custom enumerator, there MUST be custom query to properly communicate property attributes.
push(@implContent, $hasEnumerator ? "V8${interfaceName}::namedPropertyQuery, " : "0, ");
push(@implContent, $hasDeleter ? "V8${interfaceName}::namedPropertyDeleter, " : "0, ");
Modified: trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl (107050 => 107051)
--- trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2012-02-08 08:57:50 UTC (rev 107051)
@@ -31,7 +31,7 @@
module test {
interface [
ActiveDOMObject,
- DelegatingPutFunction,
+ CustomNamedSetter,
Conditional=Condition1|Condition2,
CallWith=ScriptExecutionContext,
Constructor(in DOMString str1, in [Optional=CallWithDefaultValue] DOMString str2),
Modified: trunk/Source/WebCore/css/CSSStyleDeclaration.idl (107050 => 107051)
--- trunk/Source/WebCore/css/CSSStyleDeclaration.idl 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/css/CSSStyleDeclaration.idl 2012-02-08 08:57:50 UTC (rev 107051)
@@ -24,7 +24,7 @@
interface [
JSCustomMarkFunction,
JSGenerateIsReachable=ImplRoot,
- DelegatingPutFunction,
+ CustomNamedSetter,
NamedGetter,
IndexedGetter,
CustomGetPropertyNames,
Modified: trunk/Source/WebCore/dom/DOMStringMap.idl (107050 => 107051)
--- trunk/Source/WebCore/dom/DOMStringMap.idl 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/dom/DOMStringMap.idl 2012-02-08 08:57:50 UTC (rev 107051)
@@ -30,7 +30,7 @@
NamedGetter,
CustomDeleteProperty,
CustomGetPropertyNames,
- DelegatingPutFunction,
+ CustomNamedSetter,
] DOMStringMap {
};
Modified: trunk/Source/WebCore/html/HTMLAppletElement.idl (107050 => 107051)
--- trunk/Source/WebCore/html/HTMLAppletElement.idl 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/html/HTMLAppletElement.idl 2012-02-08 08:57:50 UTC (rev 107051)
@@ -21,7 +21,7 @@
module html {
interface [
- DelegatingPutFunction,
+ CustomNamedSetter,
JSCustomGetOwnPropertySlotDelegate,
CustomCall
] HTMLAppletElement : HTMLElement {
Modified: trunk/Source/WebCore/html/HTMLEmbedElement.idl (107050 => 107051)
--- trunk/Source/WebCore/html/HTMLEmbedElement.idl 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/html/HTMLEmbedElement.idl 2012-02-08 08:57:50 UTC (rev 107051)
@@ -21,7 +21,7 @@
module html {
interface [
- DelegatingPutFunction,
+ CustomNamedSetter,
JSCustomGetOwnPropertySlotDelegate,
CustomCall
] HTMLEmbedElement : HTMLElement {
Modified: trunk/Source/WebCore/html/HTMLObjectElement.idl (107050 => 107051)
--- trunk/Source/WebCore/html/HTMLObjectElement.idl 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/html/HTMLObjectElement.idl 2012-02-08 08:57:50 UTC (rev 107051)
@@ -21,7 +21,7 @@
module html {
interface [
- DelegatingPutFunction,
+ CustomNamedSetter,
JSCustomGetOwnPropertySlotDelegate,
CustomCall
] HTMLObjectElement : HTMLElement {
Modified: trunk/Source/WebCore/page/History.idl (107050 => 107051)
--- trunk/Source/WebCore/page/History.idl 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/page/History.idl 2012-02-08 08:57:50 UTC (rev 107051)
@@ -30,7 +30,7 @@
CheckDomainSecurity,
#endif
JSCustomGetOwnPropertySlotDelegate,
- DelegatingPutFunction,
+ CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
Modified: trunk/Source/WebCore/page/Location.idl (107050 => 107051)
--- trunk/Source/WebCore/page/Location.idl 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/page/Location.idl 2012-02-08 08:57:50 UTC (rev 107051)
@@ -33,7 +33,7 @@
CheckDomainSecurity,
#endif
JSCustomGetOwnPropertySlotDelegate,
- DelegatingPutFunction,
+ CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
Modified: trunk/Source/WebCore/storage/Storage.idl (107050 => 107051)
--- trunk/Source/WebCore/storage/Storage.idl 2012-02-08 08:57:08 UTC (rev 107050)
+++ trunk/Source/WebCore/storage/Storage.idl 2012-02-08 08:57:50 UTC (rev 107051)
@@ -30,7 +30,7 @@
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
- DelegatingPutFunction,
+ CustomNamedSetter,
] Storage {
readonly attribute [NotEnumerable] unsigned long length;
[NotEnumerable, ConvertNullStringTo=Null] DOMString key(in unsigned long index);
