Title: [287389] trunk/Tools
Revision
287389
Author
carlo...@webkit.org
Date
2021-12-23 00:55:22 -0800 (Thu, 23 Dec 2021)

Log Message

[GTK][a11y] WTR: ensure the root object is created before getting the focused element with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=234597

Reviewed by Adrian Perez de Castro.

This is causing some tests to fail when executed in the same web process after another test.

* WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp:
(WTR::AccessibilityController::focusedElement):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (287388 => 287389)


--- trunk/Tools/ChangeLog	2021-12-23 08:54:35 UTC (rev 287388)
+++ trunk/Tools/ChangeLog	2021-12-23 08:55:22 UTC (rev 287389)
@@ -1,5 +1,17 @@
 2021-12-23  Carlos Garcia Campos  <cgar...@igalia.com>
 
+        [GTK][a11y] WTR: ensure the root object is created before getting the focused element with ATSPI
+        https://bugs.webkit.org/show_bug.cgi?id=234597
+
+        Reviewed by Adrian Perez de Castro.
+
+        This is causing some tests to fail when executed in the same web process after another test.
+
+        * WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp:
+        (WTR::AccessibilityController::focusedElement):
+
+2021-12-23  Carlos Garcia Campos  <cgar...@igalia.com>
+
         [GTK][a11y] WTR: add support for notifications when building with ATSPI
         https://bugs.webkit.org/show_bug.cgi?id=234550
 

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp (287388 => 287389)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp	2021-12-23 08:54:35 UTC (rev 287388)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp	2021-12-23 08:55:22 UTC (rev 287389)
@@ -101,6 +101,9 @@
 RefPtr<AccessibilityUIElement> AccessibilityController::focusedElement()
 {
     WKBundlePageRef page = InjectedBundle::singleton().page()->page();
+    if (!WKAccessibilityRootObject(page))
+        return nullptr;
+
     if (auto* element = static_cast<WebCore::AccessibilityObjectAtspi*>(WKAccessibilityFocusedObject(page)))
         return AccessibilityUIElement::create(element);
     return nullptr;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to