- Revision
- 287516
- Author
- commit-qu...@webkit.org
- Date
- 2022-01-02 07:38:03 -0800 (Sun, 02 Jan 2022)
Log Message
Remove unused AbstractMacroAssembler::repatchJumpToNop() function
https://bugs.webkit.org/show_bug.cgi?id=234777
Patch by Zan Dobersek <zdober...@igalia.com> on 2022-01-02
Reviewed by Yusuke Suzuki.
Remove the unused AbstractMacroAssembler::repatchJumpToNop() function,
along with the underlying relinkJumpToNop() functions on ISA-specific
assembler classes.
* assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::relinkJumpToNop): Deleted.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::relinkJumpToNop): Deleted.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::repatchJumpToNop): Deleted.
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::relinkJumpToNop): Deleted.
* assembler/RISCV64Assembler.h:
(JSC::RISCV64Assembler::relinkJumpToNop): Deleted.
* assembler/X86Assembler.h:
(JSC::X86Assembler::relinkJumpToNop): Deleted.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (287515 => 287516)
--- trunk/Source/_javascript_Core/ChangeLog 2022-01-02 15:07:58 UTC (rev 287515)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-01-02 15:38:03 UTC (rev 287516)
@@ -1,5 +1,29 @@
2022-01-02 Zan Dobersek <zdober...@igalia.com>
+ Remove unused AbstractMacroAssembler::repatchJumpToNop() function
+ https://bugs.webkit.org/show_bug.cgi?id=234777
+
+ Reviewed by Yusuke Suzuki.
+
+ Remove the unused AbstractMacroAssembler::repatchJumpToNop() function,
+ along with the underlying relinkJumpToNop() functions on ISA-specific
+ assembler classes.
+
+ * assembler/ARM64Assembler.h:
+ (JSC::ARM64Assembler::relinkJumpToNop): Deleted.
+ * assembler/ARMv7Assembler.h:
+ (JSC::ARMv7Assembler::relinkJumpToNop): Deleted.
+ * assembler/AbstractMacroAssembler.h:
+ (JSC::AbstractMacroAssembler::repatchJumpToNop): Deleted.
+ * assembler/MIPSAssembler.h:
+ (JSC::MIPSAssembler::relinkJumpToNop): Deleted.
+ * assembler/RISCV64Assembler.h:
+ (JSC::RISCV64Assembler::relinkJumpToNop): Deleted.
+ * assembler/X86Assembler.h:
+ (JSC::X86Assembler::relinkJumpToNop): Deleted.
+
+2022-01-02 Zan Dobersek <zdober...@igalia.com>
+
[RISCV64] Make DFG, FTL, B3, WASM buildable on CPU(RISCV64)
https://bugs.webkit.org/show_bug.cgi?id=234775
Modified: trunk/Source/_javascript_Core/assembler/ARM64Assembler.h (287515 => 287516)
--- trunk/Source/_javascript_Core/assembler/ARM64Assembler.h 2022-01-02 15:07:58 UTC (rev 287515)
+++ trunk/Source/_javascript_Core/assembler/ARM64Assembler.h 2022-01-02 15:38:03 UTC (rev 287516)
@@ -2883,11 +2883,6 @@
cacheFlush(from, sizeof(int));
}
- static void relinkJumpToNop(void* from)
- {
- relinkJump(from, static_cast<char*>(from) + 4);
- }
-
static void relinkCall(void* from, void* to)
{
relinkJumpOrCall<BranchType_CALL>(reinterpret_cast<int*>(from) - 1, reinterpret_cast<const int*>(from) - 1, to);
Modified: trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h (287515 => 287516)
--- trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2022-01-02 15:07:58 UTC (rev 287515)
+++ trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h 2022-01-02 15:38:03 UTC (rev 287516)
@@ -2332,11 +2332,6 @@
cacheFlush(reinterpret_cast<uint16_t*>(from) - 5, 5 * sizeof(uint16_t));
}
- static void relinkJumpToNop(void* from)
- {
- relinkJump(from, from);
- }
-
static void relinkCall(void* from, void* to)
{
ASSERT(!(reinterpret_cast<intptr_t>(from) & 1));
Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (287515 => 287516)
--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2022-01-02 15:07:58 UTC (rev 287515)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h 2022-01-02 15:38:03 UTC (rev 287516)
@@ -899,12 +899,6 @@
AssemblerType::relinkJump(jump.dataLocation(), destination.dataLocation());
}
- template<PtrTag jumpTag>
- static void repatchJumpToNop(CodeLocationJump<jumpTag> jump)
- {
- AssemblerType::relinkJumpToNop(jump.dataLocation());
- }
-
template<PtrTag callTag, PtrTag destTag>
static void repatchNearCall(CodeLocationNearCall<callTag> nearCall, CodeLocationLabel<destTag> destination)
{
Modified: trunk/Source/_javascript_Core/assembler/MIPSAssembler.h (287515 => 287516)
--- trunk/Source/_javascript_Core/assembler/MIPSAssembler.h 2022-01-02 15:07:58 UTC (rev 287515)
+++ trunk/Source/_javascript_Core/assembler/MIPSAssembler.h 2022-01-02 15:38:03 UTC (rev 287516)
@@ -833,11 +833,6 @@
cacheFlush(insn, flushSize);
}
- static void relinkJumpToNop(void* from)
- {
- relinkJump(from, from);
- }
-
static void relinkCall(void* from, void* to)
{
void* start;
Modified: trunk/Source/_javascript_Core/assembler/RISCV64Assembler.h (287515 => 287516)
--- trunk/Source/_javascript_Core/assembler/RISCV64Assembler.h 2022-01-02 15:07:58 UTC (rev 287515)
+++ trunk/Source/_javascript_Core/assembler/RISCV64Assembler.h 2022-01-02 15:38:03 UTC (rev 287516)
@@ -1635,11 +1635,6 @@
cacheFlush(location, sizeof(uint32_t) * 2);
}
- static void relinkJumpToNop(void*)
- {
- RELEASE_ASSERT_NOT_REACHED();
- }
-
static void relinkCall(void* from, void* to)
{
uint32_t* location = reinterpret_cast<uint32_t*>(from);
Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (287515 => 287516)
--- trunk/Source/_javascript_Core/assembler/X86Assembler.h 2022-01-02 15:07:58 UTC (rev 287515)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h 2022-01-02 15:38:03 UTC (rev 287516)
@@ -3794,11 +3794,6 @@
setRel32(from, to);
}
- static void relinkJumpToNop(void* from)
- {
- setInt32(from, 0);
- }
-
static void relinkCall(void* from, void* to)
{
setRel32(from, to);
