Title: [287828] trunk/Source/WebCore
- Revision
- 287828
- Author
- grao...@webkit.org
- Date
- 2022-01-09 13:38:56 -0800 (Sun, 09 Jan 2022)
Log Message
Style::Resolver::keyframeRulesForName() signature should be improved
https://bugs.webkit.org/show_bug.cgi?id=235021
Reviewed by Darin Adler.
Darin pointed out during the review for bug 235008 that the method itself
should be const, not its return value.
* style/StyleResolver.cpp:
(WebCore::Style::Resolver::keyframeRulesForName const):
(WebCore::Style::Resolver::keyframeRulesForName): Deleted.
* style/StyleResolver.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (287827 => 287828)
--- trunk/Source/WebCore/ChangeLog 2022-01-09 21:19:45 UTC (rev 287827)
+++ trunk/Source/WebCore/ChangeLog 2022-01-09 21:38:56 UTC (rev 287828)
@@ -1,5 +1,20 @@
2022-01-09 Antoine Quint <grao...@webkit.org>
+ Style::Resolver::keyframeRulesForName() signature should be improved
+ https://bugs.webkit.org/show_bug.cgi?id=235021
+
+ Reviewed by Darin Adler.
+
+ Darin pointed out during the review for bug 235008 that the method itself
+ should be const, not its return value.
+
+ * style/StyleResolver.cpp:
+ (WebCore::Style::Resolver::keyframeRulesForName const):
+ (WebCore::Style::Resolver::keyframeRulesForName): Deleted.
+ * style/StyleResolver.h:
+
+2022-01-09 Antoine Quint <grao...@webkit.org>
+
Implicit keyframe for a CSS Animation should always use the underlying style
https://bugs.webkit.org/show_bug.cgi?id=235014
Modified: trunk/Source/WebCore/style/StyleResolver.cpp (287827 => 287828)
--- trunk/Source/WebCore/style/StyleResolver.cpp 2022-01-09 21:19:45 UTC (rev 287827)
+++ trunk/Source/WebCore/style/StyleResolver.cpp 2022-01-09 21:38:56 UTC (rev 287828)
@@ -307,7 +307,7 @@
return m_keyframesRuleMap.find(AtomString(name).impl()) != m_keyframesRuleMap.end();
}
-const Vector<Ref<StyleRuleKeyframe>> Resolver::keyframeRulesForName(const AtomString& animationName)
+Vector<Ref<StyleRuleKeyframe>> Resolver::keyframeRulesForName(const AtomString& animationName) const
{
if (animationName.isEmpty())
return { };
Modified: trunk/Source/WebCore/style/StyleResolver.h (287827 => 287828)
--- trunk/Source/WebCore/style/StyleResolver.h 2022-01-09 21:19:45 UTC (rev 287827)
+++ trunk/Source/WebCore/style/StyleResolver.h 2022-01-09 21:38:56 UTC (rev 287828)
@@ -139,7 +139,7 @@
std::optional<DynamicMediaQueryEvaluationChanges> evaluateDynamicMediaQueries();
void addKeyframeStyle(Ref<StyleRuleKeyframes>&&);
- const Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&);
+ Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&) const;
bool usesFirstLineRules() const { return m_ruleSets.features().usesFirstLineRules; }
bool usesFirstLetterRules() const { return m_ruleSets.features().usesFirstLetterRules; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
