Title: [288077] trunk/Source/WebCore
Revision
288077
Author
mmaxfi...@apple.com
Date
2022-01-16 17:04:56 -0800 (Sun, 16 Jan 2022)

Log Message

[Win] Use character names instead of codepoint values in overrideControlCharacters()
https://bugs.webkit.org/show_bug.cgi?id=235283

Reviewed by Cameron McCormack.

It's simply easier to read.

No new tests because there is no behavior change.

* platform/graphics/Font.cpp:
(WebCore::overrideControlCharacters):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (288076 => 288077)


--- trunk/Source/WebCore/ChangeLog	2022-01-16 22:10:02 UTC (rev 288076)
+++ trunk/Source/WebCore/ChangeLog	2022-01-17 01:04:56 UTC (rev 288077)
@@ -1,3 +1,17 @@
+2022-01-16  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        [Win] Use character names instead of codepoint values in overrideControlCharacters()
+        https://bugs.webkit.org/show_bug.cgi?id=235283
+
+        Reviewed by Cameron McCormack.
+
+        It's simply easier to read.
+
+        No new tests because there is no behavior change.
+
+        * platform/graphics/Font.cpp:
+        (WebCore::overrideControlCharacters):
+
 2022-01-16  Cameron McCormack  <hey...@apple.com>
 
         Ensure in flight layer transactions don't accumulate further canvas drawing

Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (288076 => 288077)


--- trunk/Source/WebCore/platform/graphics/Font.cpp	2022-01-16 22:10:02 UTC (rev 288076)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp	2022-01-17 01:04:56 UTC (rev 288077)
@@ -333,11 +333,11 @@
     };
 
     // Code points 0x0 - 0x20 and 0x7F - 0xA0 are control character and shouldn't render. Map them to ZERO WIDTH SPACE.
-    overwriteCodePoints(0x0, 0x20, zeroWidthSpace);
-    overwriteCodePoints(0x7F, 0xA0, zeroWidthSpace);
+    overwriteCodePoints(nullCharacter, space, zeroWidthSpace);
+    overwriteCodePoints(deleteCharacter, noBreakSpace, zeroWidthSpace);
     overwriteCodePoint(softHyphen, zeroWidthSpace);
-    overwriteCodePoint('\n', space);
-    overwriteCodePoint('\t', space);
+    overwriteCodePoint(newlineCharacter, space);
+    overwriteCodePoint(tabCharacter, space);
     overwriteCodePoint(noBreakSpace, space);
     overwriteCodePoint(leftToRightMark, zeroWidthSpace);
     overwriteCodePoint(rightToLeftMark, zeroWidthSpace);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to