Title: [107138] trunk/Tools
Revision
107138
Author
k...@webkit.org
Date
2012-02-08 15:20:31 -0800 (Wed, 08 Feb 2012)

Log Message

[GTK] Fails to build docs with non-standard build directories
https://bugs.webkit.org/show_bug.cgi?id=78118

* gtk/common.py:
(get_build_path): add comment to document changes done in r107098,
as requested by the reviewer and forgotten by me.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (107137 => 107138)


--- trunk/Tools/ChangeLog	2012-02-08 23:14:46 UTC (rev 107137)
+++ trunk/Tools/ChangeLog	2012-02-08 23:20:31 UTC (rev 107138)
@@ -1,3 +1,12 @@
+2012-02-08  Gustavo Noronha Silva  <g...@gnome.org>
+
+        [GTK] Fails to build docs with non-standard build directories
+        https://bugs.webkit.org/show_bug.cgi?id=78118
+
+        * gtk/common.py:
+        (get_build_path): add comment to document changes done in r107098,
+        as requested by the reviewer and forgotten by me.
+
 2012-02-08  Adam Barth  <aba...@webkit.org>
 
         Stop importing with_statement from the mysterious future

Modified: trunk/Tools/gtk/common.py (107137 => 107138)


--- trunk/Tools/gtk/common.py	2012-02-08 23:14:46 UTC (rev 107137)
+++ trunk/Tools/gtk/common.py	2012-02-08 23:20:31 UTC (rev 107138)
@@ -64,6 +64,11 @@
     if is_valid_build_directory(build_dir):
         return build_dir
 
+    # Debian and Ubuntu build both flavours of the library (with gtk2
+    # and with gtk3); they use directories build-2.0 and build-3.0 for
+    # that, which is not handled by the above cases; we check that the
+    # directory where we are called from is a valid build directory,
+    # which should handle pretty much all other non-standard cases.
     build_dir = os.getcwd()
     if is_valid_build_directory(build_dir):
         return build_dir
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to