Title: [288422] trunk/Source/WebCore
- Revision
- 288422
- Author
- commit-qu...@webkit.org
- Date
- 2022-01-23 11:27:53 -0800 (Sun, 23 Jan 2022)
Log Message
[GStreamer] C++20 warnings
https://bugs.webkit.org/show_bug.cgi?id=235493
Patch by Philippe Normand <pnorm...@igalia.com> on 2022-01-23
Reviewed by Darin Adler.
Fix ambiguous-reversed-operator warnings. In C++20 comparison operators (like a == b) need
to be declared const, so that reverse comparisons (like b == a) also work as intended.
* platform/graphics/gstreamer/GStreamerCommon.h:
(GstIteratorAdaptor::iterator::operator== const):
(GstIteratorAdaptor::iterator::operator!= const):
(GstIteratorAdaptor::iterator::operator==): Deleted.
(GstIteratorAdaptor::iterator::operator!=): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (288421 => 288422)
--- trunk/Source/WebCore/ChangeLog 2022-01-23 18:43:37 UTC (rev 288421)
+++ trunk/Source/WebCore/ChangeLog 2022-01-23 19:27:53 UTC (rev 288422)
@@ -1,3 +1,19 @@
+2022-01-23 Philippe Normand <pnorm...@igalia.com>
+
+ [GStreamer] C++20 warnings
+ https://bugs.webkit.org/show_bug.cgi?id=235493
+
+ Reviewed by Darin Adler.
+
+ Fix ambiguous-reversed-operator warnings. In C++20 comparison operators (like a == b) need
+ to be declared const, so that reverse comparisons (like b == a) also work as intended.
+
+ * platform/graphics/gstreamer/GStreamerCommon.h:
+ (GstIteratorAdaptor::iterator::operator== const):
+ (GstIteratorAdaptor::iterator::operator!= const):
+ (GstIteratorAdaptor::iterator::operator==): Deleted.
+ (GstIteratorAdaptor::iterator::operator!=): Deleted.
+
2022-01-23 Alan Bujtas <za...@apple.com>
[LFC][IFC] InlineFormattingContext::computeGeometryForLineContent should always return the line logical rect
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h (288421 => 288422)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h 2022-01-23 18:43:37 UTC (rev 288421)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h 2022-01-23 19:27:53 UTC (rev 288422)
@@ -385,11 +385,11 @@
return *this;
}
- bool operator==(const iterator& other)
+ bool operator==(const iterator& other) const
{
return m_iter == other.m_iter && m_done == other.m_done;
}
- bool operator!=(const iterator& other) { return !(*this == other); }
+ bool operator!=(const iterator& other) const { return !(*this == other); }
private:
GstIterator* m_iter;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
