Title: [288548] trunk/Tools/CISupport/ews-build/steps.py
- Revision
- 288548
- Author
- aakash_j...@apple.com
- Date
- 2022-01-25 07:52:38 -0800 (Tue, 25 Jan 2022)
Log Message
ews is displaying PR by even on patch based builds
https://bugs.webkit.org/show_bug.cgi?id=235578
Reviewed by Jonathan Bedard.
* Tools/CISupport/ews-build/steps.py:
(ConfigureBuild.add_pr_details):
Canonical link: https://commits.webkit.org/246380@main
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (288547 => 288548)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-01-25 14:39:22 UTC (rev 288547)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-01-25 15:52:38 UTC (rev 288548)
@@ -313,16 +313,16 @@
self.addURL('Patch {}'.format(patch_id), Bugzilla.patch_url(patch_id))
def add_pr_details(self):
+ pr_number = self.getProperty('github.number')
+ if not pr_number:
+ return
repository_url = self.getProperty('repository', '')
- pr_number = self.getProperty('github.number')
title = self.getProperty('github.title', '')
owners = self.getProperty('owners', [])
revision = self.getProperty('github.head.sha')
- if pr_number and title:
+ if title:
self.addURL('PR {}: {}'.format(pr_number, title), GitHub.pr_url(pr_number, repository_url))
- if pr_number and revision:
- self.addURL('Hash: {}'.format(revision[:HASH_LENGTH_TO_DISPLAY]), GitHub.commit_url(revision, repository_url))
if owners:
contributors, errors = Contributors.load(use_network=False)
for error in errors:
@@ -334,6 +334,8 @@
if display_name != github_username:
display_name = '{} ({})'.format(display_name, github_username)
self.addURL('PR by: {}'.format(display_name), '{}{}'.format(GITHUB_URL, github_username))
+ if revision:
+ self.addURL('Hash: {}'.format(revision[:HASH_LENGTH_TO_DISPLAY]), GitHub.commit_url(revision, repository_url))
class CheckOutSource(git.Git):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
