Diff
Modified: trunk/JSTests/ChangeLog (288900 => 288901)
--- trunk/JSTests/ChangeLog 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/JSTests/ChangeLog 2022-02-01 19:14:02 UTC (rev 288901)
@@ -1,3 +1,17 @@
+2022-02-01 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, reverting r288538.
+ https://bugs.webkit.org/show_bug.cgi?id=235968
+
+ `Array#groupBy` name has web-compat issue
+ <https://github.com/tc39/proposal-array-grouping/issues/37>
+
+ Reverted changeset:
+
+ "[JSC] Enable Array#groupBy and Array#groupByToMap"
+ https://bugs.webkit.org/show_bug.cgi?id=235549
+ https://commits.webkit.org/r288538
+
2022-01-28 Tom Tartarin <t...@leaningtech.com>
[JSC] Add support for WASM branch hinting proposal
Modified: trunk/JSTests/stress/unscopables.js (288900 => 288901)
--- trunk/JSTests/stress/unscopables.js 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/JSTests/stress/unscopables.js 2022-02-01 19:14:02 UTC (rev 288901)
@@ -11,7 +11,7 @@
test(typeof unscopables, "object");
test(unscopables.__proto__, undefined);
- test(String(Object.keys(unscopables).sort()), "at,copyWithin,entries,fill,find,findIndex,findLast,findLastIndex,flat,flatMap,groupBy,groupByToMap,includes,keys,values");
+ test(String(Object.keys(unscopables).sort()), "at,copyWithin,entries,fill,find,findIndex,findLast,findLastIndex,flat,flatMap,includes,keys,values");
}());
(function () {
Modified: trunk/LayoutTests/ChangeLog (288900 => 288901)
--- trunk/LayoutTests/ChangeLog 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/LayoutTests/ChangeLog 2022-02-01 19:14:02 UTC (rev 288901)
@@ -1,3 +1,17 @@
+2022-02-01 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, reverting r288538.
+ https://bugs.webkit.org/show_bug.cgi?id=235968
+
+ `Array#groupBy` name has web-compat issue
+ <https://github.com/tc39/proposal-array-grouping/issues/37>
+
+ Reverted changeset:
+
+ "[JSC] Enable Array#groupBy and Array#groupByToMap"
+ https://bugs.webkit.org/show_bug.cgi?id=235549
+ https://commits.webkit.org/r288538
+
2022-02-01 Ada Chan <ada.c...@apple.com>
[WebXR] Handle changes in XRSession's visibility state
Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (288900 => 288901)
--- trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt 2022-02-01 19:14:02 UTC (rev 288901)
@@ -74,8 +74,6 @@
indexOf
lastIndexOf
filter
- groupBy
- groupByToMap
flat
flatMap
reduce
@@ -132,8 +130,6 @@
indexOf
lastIndexOf
filter
- groupBy
- groupByToMap
flat
flatMap
reduce
@@ -175,8 +171,6 @@
indexOf
lastIndexOf
filter
- groupBy
- groupByToMap
flat
flatMap
reduce
@@ -218,8 +212,6 @@
indexOf
lastIndexOf
filter
- groupBy
- groupByToMap
flat
flatMap
reduce
Modified: trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt (288900 => 288901)
--- trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt 2022-02-01 19:14:02 UTC (rev 288901)
@@ -47,7 +47,7 @@
PASS getSortedOwnPropertyNames(Function) is ['length', 'name', 'prototype']
PASS getSortedOwnPropertyNames(Function.prototype) is ['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']
PASS getSortedOwnPropertyNames(Array) is ['from', 'isArray', 'length', 'name', 'of', 'prototype']
-PASS getSortedOwnPropertyNames(Array.prototype) is ['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'groupBy', 'groupByToMap', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']
+PASS getSortedOwnPropertyNames(Array.prototype) is ['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']
PASS getSortedOwnPropertyNames(String) is ['fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']
PASS getSortedOwnPropertyNames(String.prototype) is ['anchor', 'at', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'matchAll', 'normalize', 'padEnd', 'padStart', 'repeat', 'replace', 'replaceAll', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimEnd', 'trimLeft', 'trimRight', 'trimStart', 'valueOf']
PASS getSortedOwnPropertyNames(Boolean) is ['length', 'name', 'prototype']
Modified: trunk/LayoutTests/js/array-unscopables-properties-expected.txt (288900 => 288901)
--- trunk/LayoutTests/js/array-unscopables-properties-expected.txt 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/LayoutTests/js/array-unscopables-properties-expected.txt 2022-02-01 19:14:02 UTC (rev 288901)
@@ -50,14 +50,6 @@
PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flatMap").writable is true
PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flatMap").enumerable is true
PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "flatMap").configurable is true
-PASS Array.prototype[Symbol.unscopables]["groupBy"] is true
-PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "groupBy").writable is true
-PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "groupBy").enumerable is true
-PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "groupBy").configurable is true
-PASS Array.prototype[Symbol.unscopables]["groupByToMap"] is true
-PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "groupByToMap").writable is true
-PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "groupByToMap").enumerable is true
-PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "groupByToMap").configurable is true
PASS Array.prototype[Symbol.unscopables]["includes"] is true
PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "includes").writable is true
PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "includes").enumerable is true
Modified: trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js (288900 => 288901)
--- trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js 2022-02-01 19:14:02 UTC (rev 288901)
@@ -56,7 +56,7 @@
"Function": "['length', 'name', 'prototype']",
"Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']",
"Array": "['from', 'isArray', 'length', 'name', 'of', 'prototype']",
- "Array.prototype": "['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'groupBy', 'groupByToMap', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']",
+ "Array.prototype": "['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']",
"String": "['fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']",
"String.prototype": "['anchor', 'at', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'matchAll', 'normalize', 'padEnd', 'padStart', 'repeat', 'replace', 'replaceAll', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimEnd', 'trimLeft', 'trimRight', 'trimStart', 'valueOf']",
"Boolean": "['length', 'name', 'prototype']",
Modified: trunk/LayoutTests/js/script-tests/array-unscopables-properties.js (288900 => 288901)
--- trunk/LayoutTests/js/script-tests/array-unscopables-properties.js 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/LayoutTests/js/script-tests/array-unscopables-properties.js 2022-02-01 19:14:02 UTC (rev 288901)
@@ -17,8 +17,6 @@
"findLastIndex",
"flat",
"flatMap",
- "groupBy",
- "groupByToMap",
"includes",
"keys",
"values"
Modified: trunk/Source/_javascript_Core/ChangeLog (288900 => 288901)
--- trunk/Source/_javascript_Core/ChangeLog 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-02-01 19:14:02 UTC (rev 288901)
@@ -1,3 +1,17 @@
+2022-02-01 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, reverting r288538.
+ https://bugs.webkit.org/show_bug.cgi?id=235968
+
+ `Array#groupBy` name has web-compat issue
+ <https://github.com/tc39/proposal-array-grouping/issues/37>
+
+ Reverted changeset:
+
+ "[JSC] Enable Array#groupBy and Array#groupByToMap"
+ https://bugs.webkit.org/show_bug.cgi?id=235549
+ https://commits.webkit.org/r288538
+
2022-02-01 Mark Lam <mark....@apple.com>
Enhance sanitizeStackForVM() to assist with crash analysis.
Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (288900 => 288901)
--- trunk/Source/_javascript_Core/runtime/OptionsList.h 2022-02-01 19:12:52 UTC (rev 288900)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h 2022-02-01 19:14:02 UTC (rev 288901)
@@ -538,7 +538,7 @@
/* Feature Flags */\
\
v(Bool, useArrayFindLastMethod, true, Normal, "Expose the findLast() and findLastIndex() methods on Array and %TypedArray%.") \
- v(Bool, useArrayGroupByMethod, true, Normal, "Expose the groupBy() and groupByToMap() methods on Array.") \
+ v(Bool, useArrayGroupByMethod, false, Normal, "Expose the groupBy() and groupByToMap() methods on Array.") \
v(Bool, useAtMethod, true, Normal, "Expose the at() method on Array, %TypedArray%, and String.") \
v(Bool, useHasOwn, true, Normal, "Expose the Object.hasOwn method") \
v(Bool, useImportAssertion, false, Normal, "Enable import assertion.") \
