Title: [289158] trunk/Source/WebCore
- Revision
- 289158
- Author
- grao...@webkit.org
- Date
- 2022-02-05 09:51:40 -0800 (Sat, 05 Feb 2022)
Log Message
[Web Animations] Address KeyframeEffect::isAboutToRunAccelerated() FIXME
https://bugs.webkit.org/show_bug.cgi?id=236178
Reviewed by Dean Jackson.
The canBeAccelerated() function catches all the cases to determine whether an effect
can be accelerated prior to being committed to a GraphicsLayerCA animation.
* animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::isAboutToRunAccelerated const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (289157 => 289158)
--- trunk/Source/WebCore/ChangeLog 2022-02-05 16:37:37 UTC (rev 289157)
+++ trunk/Source/WebCore/ChangeLog 2022-02-05 17:51:40 UTC (rev 289158)
@@ -1,3 +1,16 @@
+2022-02-05 Antoine Quint <grao...@webkit.org>
+
+ [Web Animations] Address KeyframeEffect::isAboutToRunAccelerated() FIXME
+ https://bugs.webkit.org/show_bug.cgi?id=236178
+
+ Reviewed by Dean Jackson.
+
+ The canBeAccelerated() function catches all the cases to determine whether an effect
+ can be accelerated prior to being committed to a GraphicsLayerCA animation.
+
+ * animation/KeyframeEffect.h:
+ (WebCore::KeyframeEffect::isAboutToRunAccelerated const):
+
2022-02-05 Alan Bujtas <za...@apple.com>
[RenderTreeBuilder] Clean up column spanners when style change affects containing block
Modified: trunk/Source/WebCore/animation/KeyframeEffect.h (289157 => 289158)
--- trunk/Source/WebCore/animation/KeyframeEffect.h 2022-02-05 16:37:37 UTC (rev 289157)
+++ trunk/Source/WebCore/animation/KeyframeEffect.h 2022-02-05 17:51:40 UTC (rev 289158)
@@ -135,8 +135,7 @@
bool triggersStackingContext() const { return m_triggersStackingContext; }
bool isRunningAccelerated() const { return m_runningAccelerated == RunningAccelerated::Yes; }
- // FIXME: These ignore the fact that some timing functions can prevent acceleration.
- bool isAboutToRunAccelerated() const { return m_acceleratedPropertiesState != AcceleratedProperties::None && m_lastRecordedAcceleratedAction != AcceleratedAction::Stop; }
+ bool isAboutToRunAccelerated() const { return canBeAccelerated() && m_lastRecordedAcceleratedAction != AcceleratedAction::Stop; }
bool filterFunctionListsMatch() const override { return m_filterFunctionListsMatch; }
bool transformFunctionListsMatch() const override { return m_transformFunctionListsMatch; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
